From 23955d956e799538b3e05fcd967390a541cfe473 Mon Sep 17 00:00:00 2001
From: Shuhei Kitagawa <shuheiktgw@users.noreply.github.com>
Date: Sun, 24 Jun 2018 19:55:55 +0900
Subject: Add tests for remote_unfollows_controller (#7879)

---
 app/controllers/remote_unfollows.rb                | 39 ----------------------
 app/controllers/remote_unfollows_controller.rb     | 39 ++++++++++++++++++++++
 .../remote_unfollows_controller_spec.rb            | 38 +++++++++++++++++++++
 3 files changed, 77 insertions(+), 39 deletions(-)
 delete mode 100644 app/controllers/remote_unfollows.rb
 create mode 100644 app/controllers/remote_unfollows_controller.rb
 create mode 100644 spec/controllers/remote_unfollows_controller_spec.rb

diff --git a/app/controllers/remote_unfollows.rb b/app/controllers/remote_unfollows.rb
deleted file mode 100644
index af5943363..000000000
--- a/app/controllers/remote_unfollows.rb
+++ /dev/null
@@ -1,39 +0,0 @@
-# frozen_string_literal: true
-
-class RemoteUnfollowsController < ApplicationController
-  layout 'modal'
-
-  before_action :authenticate_user!
-  before_action :set_body_classes
-
-  def create
-    @account = unfollow_attempt.try(:target_account)
-
-    if @account.nil?
-      render :error
-    else
-      render :success
-    end
-  rescue ActiveRecord::RecordNotFound, Mastodon::NotPermittedError
-    render :error
-  end
-
-  private
-
-  def unfollow_attempt
-    username, domain = acct_without_prefix.split('@')
-    UnfollowService.new.call(current_account, Account.find_remote!(username, domain))
-  end
-
-  def acct_without_prefix
-    acct_params.gsub(/\Aacct:/, '')
-  end
-
-  def acct_params
-    params.fetch(:acct, '')
-  end
-
-  def set_body_classes
-    @body_classes = 'modal-layout'
-  end
-end
diff --git a/app/controllers/remote_unfollows_controller.rb b/app/controllers/remote_unfollows_controller.rb
new file mode 100644
index 000000000..af5943363
--- /dev/null
+++ b/app/controllers/remote_unfollows_controller.rb
@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+class RemoteUnfollowsController < ApplicationController
+  layout 'modal'
+
+  before_action :authenticate_user!
+  before_action :set_body_classes
+
+  def create
+    @account = unfollow_attempt.try(:target_account)
+
+    if @account.nil?
+      render :error
+    else
+      render :success
+    end
+  rescue ActiveRecord::RecordNotFound, Mastodon::NotPermittedError
+    render :error
+  end
+
+  private
+
+  def unfollow_attempt
+    username, domain = acct_without_prefix.split('@')
+    UnfollowService.new.call(current_account, Account.find_remote!(username, domain))
+  end
+
+  def acct_without_prefix
+    acct_params.gsub(/\Aacct:/, '')
+  end
+
+  def acct_params
+    params.fetch(:acct, '')
+  end
+
+  def set_body_classes
+    @body_classes = 'modal-layout'
+  end
+end
diff --git a/spec/controllers/remote_unfollows_controller_spec.rb b/spec/controllers/remote_unfollows_controller_spec.rb
new file mode 100644
index 000000000..223ed64af
--- /dev/null
+++ b/spec/controllers/remote_unfollows_controller_spec.rb
@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe RemoteUnfollowsController do
+  render_views
+
+  describe '#create' do
+    subject { post :create, params: { acct: acct } }
+
+    let(:current_user) { Fabricate(:user, account: current_account) }
+    let(:current_account) { Fabricate(:account) }
+    let(:remote_account) { Fabricate(:user, email: 'bob@example.com', account: Fabricate(:account, username: 'bob', protocol: :activitypub, domain: 'example.com', inbox_url: 'http://example.com/inbox')).account }
+    before do
+      sign_in current_user
+      current_account.follow!(remote_account)
+      stub_request(:post, 'http://example.com/inbox'){ { status: 200 } }
+    end
+
+    context 'when successfully unfollow remote account' do
+      let(:acct) {"acct:#{ remote_account.username }@#{ remote_account.domain }"}
+
+      it do
+        is_expected.to render_template :success
+        expect(current_account.following?(remote_account)).to be false
+      end
+    end
+
+    context 'when fails to unfollow remote account' do
+      let(:acct) {"acct:#{ remote_account.username + '_test' }@#{ remote_account.domain }"}
+
+      it do
+        is_expected.to render_template :error
+        expect(current_account.following?(remote_account)).to be true
+      end
+    end
+  end
+end
-- 
cgit