From 72591cc6d59d774e66d1d42af44bdc00f71f99f8 Mon Sep 17 00:00:00 2001 From: Eugen Rochko Date: Wed, 31 Aug 2016 16:15:12 +0200 Subject: Cleaning up action names and compose drawer --- .../javascripts/components/actions/compose.jsx | 49 +++++++++++++ app/assets/javascripts/components/actions/meta.jsx | 4 +- .../javascripts/components/actions/statuses.jsx | 81 ---------------------- .../javascripts/components/actions/timelines.jsx | 19 +++++ app/assets/javascripts/components/api.jsx | 11 +++ .../javascripts/components/components/avatar.jsx | 4 ++ .../javascripts/components/components/button.jsx | 13 +++- .../components/components/character_counter.jsx | 5 ++ .../javascripts/components/components/column.jsx | 7 +- .../components/components/column_header.jsx | 8 ++- .../components/components/columns_area.jsx | 8 ++- .../components/components/composer_drawer.jsx | 26 ++++--- .../components/components/display_name.jsx | 4 ++ .../javascripts/components/components/frontend.jsx | 8 ++- .../javascripts/components/components/nav_bar.jsx | 12 ---- .../components/components/relative_timestamp.jsx | 6 +- .../javascripts/components/components/status.jsx | 5 ++ .../components/components/status_list.jsx | 7 +- .../containers/composer_drawer_container.jsx | 19 +++-- .../javascripts/components/containers/root.jsx | 18 ++--- .../containers/status_list_container.jsx | 2 +- .../javascripts/components/reducers/compose.jsx | 25 +++++++ .../javascripts/components/reducers/index.jsx | 8 ++- .../javascripts/components/reducers/meta.jsx | 4 +- .../javascripts/components/reducers/statuses.jsx | 17 ----- .../javascripts/components/reducers/timelines.jsx | 17 +++++ .../components/store/configureStore.jsx | 6 +- 27 files changed, 232 insertions(+), 161 deletions(-) create mode 100644 app/assets/javascripts/components/actions/compose.jsx delete mode 100644 app/assets/javascripts/components/actions/statuses.jsx create mode 100644 app/assets/javascripts/components/actions/timelines.jsx create mode 100644 app/assets/javascripts/components/api.jsx delete mode 100644 app/assets/javascripts/components/components/nav_bar.jsx create mode 100644 app/assets/javascripts/components/reducers/compose.jsx delete mode 100644 app/assets/javascripts/components/reducers/statuses.jsx create mode 100644 app/assets/javascripts/components/reducers/timelines.jsx (limited to 'app/assets/javascripts') diff --git a/app/assets/javascripts/components/actions/compose.jsx b/app/assets/javascripts/components/actions/compose.jsx new file mode 100644 index 000000000..614ed1a89 --- /dev/null +++ b/app/assets/javascripts/components/actions/compose.jsx @@ -0,0 +1,49 @@ +import api from '../api' + +export const COMPOSE_CHANGE = 'COMPOSE_CHANGE'; +export const COMPOSE_SUBMIT = 'COMPOSE_SUBMIT'; +export const COMPOSE_SUBMIT_REQUEST = 'COMPOSE_SUBMIT_REQUEST'; +export const COMPOSE_SUBMIT_SUCCESS = 'COMPOSE_SUBMIT_SUCCESS'; +export const COMPOSE_SUBMIT_FAIL = 'COMPOSE_SUBMIT_FAIL'; + +export function changeCompose(text) { + return { + type: COMPOSE_CHANGE, + text: text + }; +} + +export function submitCompose() { + return function (dispatch, getState) { + dispatch(submitComposeRequest()); + + api(getState).post('/api/statuses', { + status: getState().getIn(['compose', 'text'], ''), + in_reply_to_id: getState().getIn(['compose', 'in_reply_to_id'], null) + }).then(function (response) { + dispatch(submitComposeSuccess(response.data)); + }).catch(function (error) { + dispatch(submitComposeFail(error)); + }); + }; +} + +export function submitComposeRequest() { + return { + type: COMPOSE_SUBMIT_REQUEST + }; +} + +export function submitComposeSuccess(response) { + return { + type: COMPOSE_SUBMIT_SUCCESS + }; +} + +export function submitComposeFail(error) { + return { + type: COMPOSE_SUBMIT_FAIL, + error: error + }; +} + diff --git a/app/assets/javascripts/components/actions/meta.jsx b/app/assets/javascripts/components/actions/meta.jsx index 1b64db1c2..e0f127231 100644 --- a/app/assets/javascripts/components/actions/meta.jsx +++ b/app/assets/javascripts/components/actions/meta.jsx @@ -1,8 +1,8 @@ -export const SET_ACCESS_TOKEN = 'SET_ACCESS_TOKEN'; +export const ACCESS_TOKEN_SET = 'ACCESS_TOKEN_SET'; export function setAccessToken(token) { return { - type: SET_ACCESS_TOKEN, + type: ACCESS_TOKEN_SET, token: token }; } diff --git a/app/assets/javascripts/components/actions/statuses.jsx b/app/assets/javascripts/components/actions/statuses.jsx deleted file mode 100644 index 45d62fab2..000000000 --- a/app/assets/javascripts/components/actions/statuses.jsx +++ /dev/null @@ -1,81 +0,0 @@ -import fetch from 'isomorphic-fetch' - -export const SET_TIMELINE = 'SET_TIMELINE'; -export const ADD_STATUS = 'ADD_STATUS'; - -export const PUBLISH = 'PUBLISH'; -export const PUBLISH_START = 'PUBLISH_START'; -export const PUBLISH_SUCC = 'PUBLISH_SUCC'; -export const PUBLISH_ERROR = 'PUBLISH_ERROR'; - -export function setTimeline(timeline, statuses) { - return { - type: SET_TIMELINE, - timeline: timeline, - statuses: statuses - }; -} - -export function addStatus(timeline, status) { - return { - type: ADD_STATUS, - timeline: timeline, - status: status - }; -} - -export function publishStart() { - return { - type: PUBLISH_START - }; -} - -export function publishError(error) { - return { - type: PUBLISH_ERROR, - error: error - }; -} - -export function publishSucc(status) { - return { - type: PUBLISH_SUCC, - status: status - }; -} - -export function publish(text, in_reply_to_id) { - return function (dispatch, getState) { - const access_token = getState().getIn(['meta', 'access_token']); - - var data = new FormData(); - - data.append('status', text); - - if (in_reply_to_id !== null) { - data.append('in_reply_to_id', in_reply_to_id); - } - - dispatch(publishStart()); - - return fetch('/api/statuses', { - method: 'POST', - - headers: { - 'Authorization': `Bearer ${access_token}` - }, - - body: data - }).then(function (response) { - return response.json(); - }).then(function (json) { - if (json.error) { - dispatch(publishError(json.error)); - } else { - dispatch(publishSucc(json)); - } - }).catch(function (error) { - dispatch(publishError(error)); - }); - }; -} diff --git a/app/assets/javascripts/components/actions/timelines.jsx b/app/assets/javascripts/components/actions/timelines.jsx new file mode 100644 index 000000000..91f06511a --- /dev/null +++ b/app/assets/javascripts/components/actions/timelines.jsx @@ -0,0 +1,19 @@ +export const TIMELINE_SET = 'TIMELINE_SET'; +export const TIMELINE_UPDATE = 'TIMELINE_UPDATE'; + + +export function setTimeline(timeline, statuses) { + return { + type: TIMELINE_SET, + timeline: timeline, + statuses: statuses + }; +} + +export function updateTimeline(timeline, status) { + return { + type: TIMELINE_UPDATE, + timeline: timeline, + status: status + }; +} diff --git a/app/assets/javascripts/components/api.jsx b/app/assets/javascripts/components/api.jsx new file mode 100644 index 000000000..f317af094 --- /dev/null +++ b/app/assets/javascripts/components/api.jsx @@ -0,0 +1,11 @@ +import axios from 'axios'; + +export default getState => axios.create({ + headers: { + 'Authorization': `Bearer ${getState().getIn(['meta', 'access_token'], '')}` + }, + + transformResponse: [function (data) { + return JSON.parse(data); + }] +}); diff --git a/app/assets/javascripts/components/components/avatar.jsx b/app/assets/javascripts/components/components/avatar.jsx index 7db3eeff7..abbef72f8 100644 --- a/app/assets/javascripts/components/components/avatar.jsx +++ b/app/assets/javascripts/components/components/avatar.jsx @@ -1,9 +1,13 @@ +import PureRenderMixin from 'react-addons-pure-render-mixin'; + const Avatar = React.createClass({ propTypes: { src: React.PropTypes.string.isRequired }, + mixins: [PureRenderMixin], + render () { return (
diff --git a/app/assets/javascripts/components/components/button.jsx b/app/assets/javascripts/components/components/button.jsx index b2d7ba9a9..e70382142 100644 --- a/app/assets/javascripts/components/components/button.jsx +++ b/app/assets/javascripts/components/components/button.jsx @@ -1,12 +1,21 @@ +import PureRenderMixin from 'react-addons-pure-render-mixin'; + const Button = React.createClass({ + propTypes: { text: React.PropTypes.string.isRequired, - onClick: React.PropTypes.func + onClick: React.PropTypes.func, + disabled: React.PropTypes.boolean }, + mixins: [PureRenderMixin], + handleClick (e) { e.preventDefault(); - this.props.onClick(); + + if (!this.props.disabled) { + this.props.onClick(); + } }, render () { diff --git a/app/assets/javascripts/components/components/character_counter.jsx b/app/assets/javascripts/components/components/character_counter.jsx index b58d9fe32..dd9218844 100644 --- a/app/assets/javascripts/components/components/character_counter.jsx +++ b/app/assets/javascripts/components/components/character_counter.jsx @@ -1,8 +1,13 @@ +import PureRenderMixin from 'react-addons-pure-render-mixin'; + const CharacterCounter = React.createClass({ + propTypes: { text: React.PropTypes.string.isRequired }, + mixins: [PureRenderMixin], + render () { return ( diff --git a/app/assets/javascripts/components/components/column.jsx b/app/assets/javascripts/components/components/column.jsx index c1f5b84a2..b347ee3a8 100644 --- a/app/assets/javascripts/components/components/column.jsx +++ b/app/assets/javascripts/components/components/column.jsx @@ -1,12 +1,16 @@ import StatusListContainer from '../containers/status_list_container'; import ColumnHeader from './column_header'; +import PureRenderMixin from 'react-addons-pure-render-mixin'; const Column = React.createClass({ + propTypes: { type: React.PropTypes.string }, - render: function() { + mixins: [PureRenderMixin], + + render () { return (
@@ -14,6 +18,7 @@ const Column = React.createClass({
); } + }); export default Column; diff --git a/app/assets/javascripts/components/components/column_header.jsx b/app/assets/javascripts/components/components/column_header.jsx index e2f7d7c1c..15a195898 100644 --- a/app/assets/javascripts/components/components/column_header.jsx +++ b/app/assets/javascripts/components/components/column_header.jsx @@ -1,15 +1,21 @@ +import PureRenderMixin from 'react-addons-pure-render-mixin'; + const ColumnHeader = React.createClass({ + propTypes: { type: React.PropTypes.string }, - render: function() { + mixins: [PureRenderMixin], + + render () { return (
{this.props.type}
); } + }); export default ColumnHeader; diff --git a/app/assets/javascripts/components/components/columns_area.jsx b/app/assets/javascripts/components/components/columns_area.jsx index 1c46f722d..149fdfcf4 100644 --- a/app/assets/javascripts/components/components/columns_area.jsx +++ b/app/assets/javascripts/components/components/columns_area.jsx @@ -1,8 +1,11 @@ -import Column from './column'; +import Column from './column'; +import PureRenderMixin from 'react-addons-pure-render-mixin'; const ColumnsArea = React.createClass({ - render: function() { + mixins: [PureRenderMixin], + + render () { return (
@@ -10,6 +13,7 @@ const ColumnsArea = React.createClass({
); } + }); export default ColumnsArea; diff --git a/app/assets/javascripts/components/components/composer_drawer.jsx b/app/assets/javascripts/components/components/composer_drawer.jsx index 7b742f64e..71455967f 100644 --- a/app/assets/javascripts/components/components/composer_drawer.jsx +++ b/app/assets/javascripts/components/components/composer_drawer.jsx @@ -1,42 +1,40 @@ import CharacterCounter from './character_counter'; import Button from './button'; -import { publish } from '../actions/statuses'; +import PureRenderMixin from 'react-addons-pure-render-mixin'; const ComposerDrawer = React.createClass({ propTypes: { + text: React.PropTypes.string.isRequired, + isSubmitting: React.PropTypes.boolean, + onChange: React.PropTypes.func.isRequired, onSubmit: React.PropTypes.func.isRequired }, - getInitialState() { - return { - text: '' - }; - }, + mixins: [PureRenderMixin], handleChange (e) { - this.setState({ text: e.target.value }); + this.props.onChange(e.target.value); }, handleKeyUp (e) { if (e.keyCode === 13 && e.ctrlKey) { - this.handleSubmit(); + this.props.onSubmit(); } }, handleSubmit () { - this.props.onSubmit(this.state.text, null); - this.setState({ text: '' }); + this.props.onSubmit(); }, render () { return ( -
-