From 3eede6f64b78660d94a796641620f086fa0aca87 Mon Sep 17 00:00:00 2001 From: ThibG Date: Sat, 28 Mar 2020 17:59:45 +0100 Subject: [Glitch] Fix 404 and 410 API errors being silently discarded in WebUI Port front-end changes from 0d117c106aa72f78dd5cdd371849dd8ce3120198 to glitch-soc Signed-off-by: Thibaut Girka --- app/javascript/flavours/glitch/actions/accounts.js | 3 +++ app/javascript/flavours/glitch/actions/alerts.js | 4 ++-- app/javascript/flavours/glitch/actions/identity_proofs.js | 1 + app/javascript/flavours/glitch/actions/timelines.js | 1 + app/javascript/flavours/glitch/middleware/errors.js | 2 +- 5 files changed, 8 insertions(+), 3 deletions(-) (limited to 'app/javascript/flavours/glitch') diff --git a/app/javascript/flavours/glitch/actions/accounts.js b/app/javascript/flavours/glitch/actions/accounts.js index b659e4ff3..e1012a80b 100644 --- a/app/javascript/flavours/glitch/actions/accounts.js +++ b/app/javascript/flavours/glitch/actions/accounts.js @@ -370,6 +370,7 @@ export function fetchFollowersFail(id, error) { type: FOLLOWERS_FETCH_FAIL, id, error, + skipNotFound: true, }; }; @@ -456,6 +457,7 @@ export function fetchFollowingFail(id, error) { type: FOLLOWING_FETCH_FAIL, id, error, + skipNotFound: true, }; }; @@ -545,6 +547,7 @@ export function fetchRelationshipsFail(error) { type: RELATIONSHIPS_FETCH_FAIL, error, skipLoading: true, + skipNotFound: true, }; }; diff --git a/app/javascript/flavours/glitch/actions/alerts.js b/app/javascript/flavours/glitch/actions/alerts.js index cd36d8007..1670f9c10 100644 --- a/app/javascript/flavours/glitch/actions/alerts.js +++ b/app/javascript/flavours/glitch/actions/alerts.js @@ -34,11 +34,11 @@ export function showAlert(title = messages.unexpectedTitle, message = messages.u }; }; -export function showAlertForError(error) { +export function showAlertForError(error, skipNotFound = false) { if (error.response) { const { data, status, statusText, headers } = error.response; - if (status === 404 || status === 410) { + if (skipNotFound && (status === 404 || status === 410)) { // Skip these errors as they are reflected in the UI return { type: ALERT_NOOP }; } diff --git a/app/javascript/flavours/glitch/actions/identity_proofs.js b/app/javascript/flavours/glitch/actions/identity_proofs.js index a7241da20..18e679aec 100644 --- a/app/javascript/flavours/glitch/actions/identity_proofs.js +++ b/app/javascript/flavours/glitch/actions/identity_proofs.js @@ -27,4 +27,5 @@ export const fetchAccountIdentityProofsFail = (accountId, err) => ({ type: IDENTITY_PROOFS_ACCOUNT_FETCH_FAIL, accountId, err, + skipNotFound: true, }); diff --git a/app/javascript/flavours/glitch/actions/timelines.js b/app/javascript/flavours/glitch/actions/timelines.js index 2ef78025e..1bbdd6142 100644 --- a/app/javascript/flavours/glitch/actions/timelines.js +++ b/app/javascript/flavours/glitch/actions/timelines.js @@ -165,6 +165,7 @@ export function expandTimelineFail(timeline, error, isLoadingMore) { timeline, error, skipLoading: !isLoadingMore, + skipNotFound: timeline.startsWith('account:'), }; }; diff --git a/app/javascript/flavours/glitch/middleware/errors.js b/app/javascript/flavours/glitch/middleware/errors.js index 212c1f4ad..ade529a4e 100644 --- a/app/javascript/flavours/glitch/middleware/errors.js +++ b/app/javascript/flavours/glitch/middleware/errors.js @@ -8,7 +8,7 @@ export default function errorsMiddleware() { const isFail = new RegExp(`${defaultFailSuffix}$`, 'g'); if (action.type.match(isFail)) { - dispatch(showAlertForError(action.error)); + dispatch(showAlertForError(action.error, action.skipNotFound)); } } -- cgit From dcf841545dbdcafaafa2cb436c0124efa2aaa769 Mon Sep 17 00:00:00 2001 From: "Mélanie Chauvel (ariasuni)" Date: Tue, 31 Mar 2020 12:39:50 +0200 Subject: [Glitch] Fix wrong color for ellipsis in boost confirmation dialog in Web UI Port be2f1597cf6b010a7ea0ffdc45550f87a7ae9dad to glitch-soc Signed-off-by: Thibaut Girka --- app/javascript/flavours/glitch/styles/components/status.scss | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'app/javascript/flavours/glitch') diff --git a/app/javascript/flavours/glitch/styles/components/status.scss b/app/javascript/flavours/glitch/styles/components/status.scss index fa26c4706..50b7f2a72 100644 --- a/app/javascript/flavours/glitch/styles/components/status.scss +++ b/app/javascript/flavours/glitch/styles/components/status.scss @@ -331,13 +331,11 @@ } .display-name { + color: $light-text-color; + strong { color: $inverted-text-color; } - - span { - color: $lighter-text-color; - } } .status__content { -- cgit From 9175ebf20ce9808b63b552d4ba2ceec8eaa8a67b Mon Sep 17 00:00:00 2001 From: ThibG Date: Tue, 31 Mar 2020 14:10:18 +0200 Subject: [Glitch] Fix content warning being unnecessarily cleared when enabling/disabling CW Port cf1fa73347c9ca2b1c4f14521e990feba7509e2e to glitch-soc Signed-off-by: Thibaut Girka --- app/javascript/flavours/glitch/reducers/compose.js | 1 - 1 file changed, 1 deletion(-) (limited to 'app/javascript/flavours/glitch') diff --git a/app/javascript/flavours/glitch/reducers/compose.js b/app/javascript/flavours/glitch/reducers/compose.js index 92a9859d9..f758d5c93 100644 --- a/app/javascript/flavours/glitch/reducers/compose.js +++ b/app/javascript/flavours/glitch/reducers/compose.js @@ -344,7 +344,6 @@ export default function compose(state = initialState, action) { }); case COMPOSE_SPOILERNESS_CHANGE: return state.withMutations(map => { - map.set('spoiler_text', ''); map.set('spoiler', !state.get('spoiler')); map.set('idempotencyKey', uuid()); -- cgit From 2e337d850f3fccefbe1aa7667220ef12d25201e5 Mon Sep 17 00:00:00 2001 From: "Mélanie Chauvel (ariasuni)" Date: Tue, 31 Mar 2020 19:40:23 +0200 Subject: [Glitch] Improve toot clicking areas Port part of 1fb92037e432913902a5e5c8a5b673b036d84cb8 to glitch-soc Signed-off-by: Thibaut Girka --- .../flavours/glitch/features/direct_timeline/components/conversation.js | 2 +- app/javascript/flavours/glitch/styles/components/accounts.scss | 1 - app/javascript/flavours/glitch/styles/components/index.scss | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) (limited to 'app/javascript/flavours/glitch') diff --git a/app/javascript/flavours/glitch/features/direct_timeline/components/conversation.js b/app/javascript/flavours/glitch/features/direct_timeline/components/conversation.js index ba01f8d5c..47b92560d 100644 --- a/app/javascript/flavours/glitch/features/direct_timeline/components/conversation.js +++ b/app/javascript/flavours/glitch/features/direct_timeline/components/conversation.js @@ -195,7 +195,7 @@ class Conversation extends ImmutablePureComponent { return (
-
+
diff --git a/app/javascript/flavours/glitch/styles/components/accounts.scss b/app/javascript/flavours/glitch/styles/components/accounts.scss index 6305e2a4d..491ceb6ec 100644 --- a/app/javascript/flavours/glitch/styles/components/accounts.scss +++ b/app/javascript/flavours/glitch/styles/components/accounts.scss @@ -51,7 +51,6 @@ @include avatar-radius; overflow: hidden; position: relative; - cursor: default; & div { @include avatar-radius; diff --git a/app/javascript/flavours/glitch/styles/components/index.scss b/app/javascript/flavours/glitch/styles/components/index.scss index d97ab436d..50cea8b26 100644 --- a/app/javascript/flavours/glitch/styles/components/index.scss +++ b/app/javascript/flavours/glitch/styles/components/index.scss @@ -1515,6 +1515,7 @@ padding: 10px; padding-top: 12px; position: relative; + cursor: pointer; } &__unread { -- cgit From b367dd713e5b97d79d52e9cb67042eadb241d032 Mon Sep 17 00:00:00 2001 From: Sasha Sorokin Date: Thu, 2 Apr 2020 22:10:55 +0700 Subject: [Glitch] Improve polls: option lengths & redesign Port 37b3985bfac5ffdc8e452f92869dcdefb5c92594 to glitch-soc Signed-off-by: Thibaut Girka --- app/javascript/flavours/glitch/components/poll.js | 28 +++++++++------ .../features/compose/components/poll_form.js | 2 +- app/javascript/flavours/glitch/styles/polls.scss | 40 ++++++++++++---------- 3 files changed, 40 insertions(+), 30 deletions(-) (limited to 'app/javascript/flavours/glitch') diff --git a/app/javascript/flavours/glitch/components/poll.js b/app/javascript/flavours/glitch/components/poll.js index 62965df94..46fd1e8c0 100644 --- a/app/javascript/flavours/glitch/components/poll.js +++ b/app/javascript/flavours/glitch/components/poll.js @@ -127,15 +127,7 @@ class Poll extends ImmutablePureComponent { return (
  • - {showResults && ( - - {({ width }) => - - } - - )} - -
  • ); } diff --git a/app/javascript/flavours/glitch/features/compose/components/poll_form.js b/app/javascript/flavours/glitch/features/compose/components/poll_form.js index 2dce54418..57fac10ac 100644 --- a/app/javascript/flavours/glitch/features/compose/components/poll_form.js +++ b/app/javascript/flavours/glitch/features/compose/components/poll_form.js @@ -62,7 +62,7 @@ class Option extends React.PureComponent { return (
  • -