From 604654ccb417ffdc9b48d876bea76c8bec14f360 Mon Sep 17 00:00:00 2001
From: Ondřej Hruška <ondra@ondrovo.com>
Date: Fri, 21 Jul 2017 20:33:16 +0200
Subject: New notification cleaning mode (#89)

This PR adds a new notification cleaning mode, super perfectly tuned for accessibility, and removes the previous notification cleaning functionality as it's now redundant.

* w.i.p. notif clearing mode

* Better CSS for selected notification and shorter text if Stretch is off

* wip for rebase ~

* all working in notif clearing mode, except the actual removal

* bulk delete route for piggo

* cleaning + refactor. endpoint gives 422 for some reason

* formatting

* use the right route

* fix broken destroy_multiple

* load more notifs after succ cleaning

* satisfy eslint

* Removed CSS for the old notif delete button

* Tabindex=0 is mandatory

In order to make it possible to tab to this element you must have tab index = 0. Removing this violates WCAG and makes it impossible to use the interface without good eyesight and a mouse. So nobody with certain mobility impairments, vision impairments, or brain injuries would be able to use this feature if you don't have tabindex=0

* Corrected aria-label

Previous label implied a different behavior from what actually happens

* aria role localization & made the overlay behave like a checkbox

* checkboxes css and better contrast

* color tuning for the notif overlay

* fanceh checkboxes etc and nice backgrounds

* SHUT UP TRAVIS
---
 app/javascript/glitch/components/notification/index.js | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

(limited to 'app/javascript/glitch/components/notification/index.js')

diff --git a/app/javascript/glitch/components/notification/index.js b/app/javascript/glitch/components/notification/index.js
index 556d5aea8..b2e55aad5 100644
--- a/app/javascript/glitch/components/notification/index.js
+++ b/app/javascript/glitch/components/notification/index.js
@@ -2,7 +2,6 @@
 import React from 'react';
 import ImmutablePropTypes from 'react-immutable-proptypes';
 import ImmutablePureComponent from 'react-immutable-pure-component';
-import PropTypes from 'prop-types';
 
 //  Mastodon imports  //
 
@@ -15,7 +14,6 @@ export default class Notification extends ImmutablePureComponent {
   static propTypes = {
     notification: ImmutablePropTypes.map.isRequired,
     settings: ImmutablePropTypes.map.isRequired,
-    onDeleteNotification: PropTypes.func.isRequired,
   };
 
   renderFollow (notification) {
@@ -23,7 +21,7 @@ export default class Notification extends ImmutablePureComponent {
       <NotificationFollow
         id={notification.get('id')}
         account={notification.get('account')}
-        onDeleteNotification={this.props.onDeleteNotification}
+        notification={notification}
       />
     );
   }
@@ -32,7 +30,7 @@ export default class Notification extends ImmutablePureComponent {
     return (
       <StatusContainer
         id={notification.get('status')}
-        notificationId={notification.get('id')}
+        notification={notification}
         withDismiss
       />
     );
@@ -45,7 +43,7 @@ export default class Notification extends ImmutablePureComponent {
         account={notification.get('account')}
         prepend='favourite'
         muted
-        notificationId={notification.get('id')}
+        notification={notification}
         withDismiss
       />
     );
@@ -58,7 +56,7 @@ export default class Notification extends ImmutablePureComponent {
         account={notification.get('account')}
         prepend='reblog'
         muted
-        notificationId={notification.get('id')}
+        notification={notification}
         withDismiss
       />
     );
-- 
cgit