From 8caf9e4ede78b434443cc2cd65aeaae4412b288f Mon Sep 17 00:00:00 2001 From: multiple creatures Date: Fri, 21 Feb 2020 02:04:25 -0600 Subject: remove autoreject implementation, superseded by monsterfork graylisting + upstream privacy improvements --- app/lib/activitypub/activity/accept.rb | 1 - app/lib/activitypub/activity/add.rb | 1 - app/lib/activitypub/activity/announce.rb | 1 - app/lib/activitypub/activity/create.rb | 1 - app/lib/activitypub/activity/flag.rb | 1 - app/lib/activitypub/activity/follow.rb | 1 - app/lib/activitypub/activity/like.rb | 1 - app/lib/activitypub/activity/move.rb | 1 - app/lib/activitypub/activity/update.rb | 1 - 9 files changed, 9 deletions(-) (limited to 'app/lib/activitypub') diff --git a/app/lib/activitypub/activity/accept.rb b/app/lib/activitypub/activity/accept.rb index 525d4ffd6..348ee0d1c 100644 --- a/app/lib/activitypub/activity/accept.rb +++ b/app/lib/activitypub/activity/accept.rb @@ -11,7 +11,6 @@ class ActivityPub::Activity::Accept < ActivityPub::Activity private def accept_follow - return if autoreject? return accept_follow_for_relay if relay_follow? target_account = account_from_uri(target_uri) diff --git a/app/lib/activitypub/activity/add.rb b/app/lib/activitypub/activity/add.rb index 1942448da..43c885c6f 100644 --- a/app/lib/activitypub/activity/add.rb +++ b/app/lib/activitypub/activity/add.rb @@ -2,7 +2,6 @@ class ActivityPub::Activity::Add < ActivityPub::Activity def perform - return if autoreject? return unless @json['target'].present? && value_or_id(@json['target']) == @account.featured_collection_url status = status_from_uri(object_uri) diff --git a/app/lib/activitypub/activity/announce.rb b/app/lib/activitypub/activity/announce.rb index 39b05f8f1..c9471f703 100644 --- a/app/lib/activitypub/activity/announce.rb +++ b/app/lib/activitypub/activity/announce.rb @@ -2,7 +2,6 @@ class ActivityPub::Activity::Announce < ActivityPub::Activity def perform - return if autoreject? return reject_payload! if !@options[:imported] && (delete_arrived_first?(@json['id']) || !related_to_local_activity?) original_status = status_from_object(announced_by: @account, local_only: !@account.known?) diff --git a/app/lib/activitypub/activity/create.rb b/app/lib/activitypub/activity/create.rb index 7b2d40ace..798250c9e 100644 --- a/app/lib/activitypub/activity/create.rb +++ b/app/lib/activitypub/activity/create.rb @@ -2,7 +2,6 @@ class ActivityPub::Activity::Create < ActivityPub::Activity def perform - return if autoreject? return reject_payload! if unsupported_object_type? || !@options[:imported] && (invalid_origin?(@object['id']) || Tombstone.exists?(uri: @object['id']) || !related_to_local_activity?) unless known? diff --git a/app/lib/activitypub/activity/flag.rb b/app/lib/activitypub/activity/flag.rb index 1423cedef..1659bc61f 100644 --- a/app/lib/activitypub/activity/flag.rb +++ b/app/lib/activitypub/activity/flag.rb @@ -2,7 +2,6 @@ class ActivityPub::Activity::Flag < ActivityPub::Activity def perform - return if autoreject? return if skip_reports? target_accounts = object_uris.map { |uri| account_from_uri(uri) }.compact.select(&:local?) diff --git a/app/lib/activitypub/activity/follow.rb b/app/lib/activitypub/activity/follow.rb index 8545ac096..94de89b86 100644 --- a/app/lib/activitypub/activity/follow.rb +++ b/app/lib/activitypub/activity/follow.rb @@ -4,7 +4,6 @@ class ActivityPub::Activity::Follow < ActivityPub::Activity include Payloadable def perform - return if autoreject? target_account = account_from_uri(object_uri) return if target_account.nil? || !target_account.local? || delete_arrived_first?(@json['id']) || @account.requested?(target_account) diff --git a/app/lib/activitypub/activity/like.rb b/app/lib/activitypub/activity/like.rb index 2c4a9d805..674d5fe47 100644 --- a/app/lib/activitypub/activity/like.rb +++ b/app/lib/activitypub/activity/like.rb @@ -2,7 +2,6 @@ class ActivityPub::Activity::Like < ActivityPub::Activity def perform - return if autoreject? original_status = status_from_uri(object_uri) return if original_status.nil? || !original_status.account.local? || delete_arrived_first?(@json['id']) || @account.favourited?(original_status) diff --git a/app/lib/activitypub/activity/move.rb b/app/lib/activitypub/activity/move.rb index b1c986551..d7a5f595c 100644 --- a/app/lib/activitypub/activity/move.rb +++ b/app/lib/activitypub/activity/move.rb @@ -4,7 +4,6 @@ class ActivityPub::Activity::Move < ActivityPub::Activity PROCESSING_COOLDOWN = 7.days.seconds def perform - return if autoreject? return if origin_account.uri != object_uri || processed? mark_as_processing! diff --git a/app/lib/activitypub/activity/update.rb b/app/lib/activitypub/activity/update.rb index 8fb48e073..70035325b 100644 --- a/app/lib/activitypub/activity/update.rb +++ b/app/lib/activitypub/activity/update.rb @@ -4,7 +4,6 @@ class ActivityPub::Activity::Update < ActivityPub::Activity SUPPORTED_TYPES = %w(Application Group Organization Person Service).freeze def perform - return if autoreject? if equals_or_includes_any?(@object['type'], SUPPORTED_TYPES) update_account elsif equals_or_includes_any?(@object['type'], %w(Question)) -- cgit