From 96f905f40913b915496039d188297a7949b1a6db Mon Sep 17 00:00:00 2001
From: ThibG <thib@sitedethib.com>
Date: Wed, 6 Mar 2019 19:53:57 +0100
Subject: Add optimistic lock to avoid race conditions when handling votes
 (#10196)

* Add optimistic lock to avoid race conditions when handling votes

* Force-reload polls when getting `ActiveRecord::StaleObjectError`
---
 app/models/poll_vote.rb | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'app/models/poll_vote.rb')

diff --git a/app/models/poll_vote.rb b/app/models/poll_vote.rb
index 9ad66bbf8..ad24eb691 100644
--- a/app/models/poll_vote.rb
+++ b/app/models/poll_vote.rb
@@ -32,5 +32,8 @@ class PollVote < ApplicationRecord
   def increment_counter_cache
     poll.cached_tallies[choice] = (poll.cached_tallies[choice] || 0) + 1
     poll.save
+  rescue ActiveRecord::StaleObjectError
+    poll.reload
+    retry
   end
 end
-- 
cgit