From 9fd3d7b6cdb97a8f0f47425a32f34fc5c54b94de Mon Sep 17 00:00:00 2001 From: Eugen Rochko Date: Sun, 2 Oct 2016 22:35:27 +0200 Subject: Add since_id param to feeds --- app/models/concerns/paginable.rb | 7 ++++++- app/models/feed.rb | 7 ++++--- 2 files changed, 10 insertions(+), 4 deletions(-) (limited to 'app/models') diff --git a/app/models/concerns/paginable.rb b/app/models/concerns/paginable.rb index 54552ae3d..2d35d349f 100644 --- a/app/models/concerns/paginable.rb +++ b/app/models/concerns/paginable.rb @@ -2,6 +2,11 @@ module Paginable extend ActiveSupport::Concern included do - scope :paginate_by_max_id, -> (limit, max_id) { order('id desc').limit(limit).where(max_id.nil? ? '1=1' : ['id < ?', max_id]) } + def self.paginate_by_max_id(limit, max_id = nil, since_id = nil) + query = order('id desc').limit(limit) + query = query.where('id < ?', max_id) unless max_id.blank? + query = query.where('id > ?', since_id) unless since_id.blank? + query + end end end diff --git a/app/models/feed.rb b/app/models/feed.rb index e1c915c09..4466ea14e 100644 --- a/app/models/feed.rb +++ b/app/models/feed.rb @@ -4,9 +4,10 @@ class Feed @account = account end - def get(limit, max_id = nil) - max_id = '+inf' if max_id.nil? - unhydrated = redis.zrevrangebyscore(key, "(#{max_id}", '-inf', limit: [0, limit], with_scores: true).collect(&:last).map(&:to_i) + def get(limit, max_id = nil, since_id = nil) + max_id = '+inf' if max_id.blank? + since_id = '-inf' if since_id.blank? + unhydrated = redis.zrevrangebyscore(key, "(#{max_id}", "(#{since_id}", limit: [0, limit], with_scores: true).collect(&:last).map(&:to_i) status_map = {} # If we're after most recent items and none are there, we need to precompute the feed -- cgit