From 5c8ca024eff76ab10b45df9fd8a95f77ef274d71 Mon Sep 17 00:00:00 2001 From: unarist Date: Sat, 7 Oct 2017 03:39:08 +0900 Subject: Improve error handling on LinkCrawlWorker (#5250) * Improve error handling on LinkCrawlWorker * Ignore TimeoutError and InvalidURIError too * Record errors to debug log * Enable dead job queue on LinkCrawlWorker Since most of acceptable errors were already ignored, only our side issue should go to dead job queue. * Ignore all http gem errors --- app/services/fetch_link_card_service.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'app/services/fetch_link_card_service.rb') diff --git a/app/services/fetch_link_card_service.rb b/app/services/fetch_link_card_service.rb index 4acbfae7a..cf3d78683 100644 --- a/app/services/fetch_link_card_service.rb +++ b/app/services/fetch_link_card_service.rb @@ -27,7 +27,8 @@ class FetchLinkCardService < BaseService end attach_card if @card&.persisted? - rescue HTTP::ConnectionError, OpenSSL::SSL::SSLError + rescue HTTP::Error, Addressable::URI::InvalidURIError => e + Rails.logger.debug "Error fetching link #{@url}: #{e}" nil end -- cgit