From 441d6dc734d2590b14ca010076496e652d6ef676 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Tue, 9 May 2017 13:58:18 -0400 Subject: Spec and refactor for pubsubhubbub/unsubscribe service (#2946) * Add coverage for pubsub unsubscribe service * Refactor pubsub unsubscribe service --- app/services/pubsubhubbub/unsubscribe_service.rb | 28 +++++++++++++++++++----- 1 file changed, 22 insertions(+), 6 deletions(-) (limited to 'app/services/pubsubhubbub/unsubscribe_service.rb') diff --git a/app/services/pubsubhubbub/unsubscribe_service.rb b/app/services/pubsubhubbub/unsubscribe_service.rb index 7adadf8ed..99fec8b14 100644 --- a/app/services/pubsubhubbub/unsubscribe_service.rb +++ b/app/services/pubsubhubbub/unsubscribe_service.rb @@ -1,15 +1,31 @@ # frozen_string_literal: true class Pubsubhubbub::UnsubscribeService < BaseService - def call(account, callback) - return ['Invalid topic URL', 422] if account.nil? + attr_reader :account, :callback_url - subscription = Subscription.find_by(account: account, callback_url: callback) + def call(account, callback_url) + @account = account + @callback_url = callback_url - unless subscription.nil? - Pubsubhubbub::ConfirmationWorker.perform_async(subscription.id, 'unsubscribe') + process_unsubscribe + end + + private + + def process_unsubscribe + if account.nil? + ['Invalid topic URL', 422] + else + confirm_unsubscribe unless subscription.nil? + ['', 202] end + end + + def confirm_unsubscribe + Pubsubhubbub::ConfirmationWorker.perform_async(subscription.id, 'unsubscribe') + end - ['', 202] + def subscription + @_subscription ||= Subscription.find_by(account: account, callback_url: callback_url) end end -- cgit