From f92f1ee80a90fcc88afc4519c0b70f369fef6f62 Mon Sep 17 00:00:00 2001 From: Eugen Rochko Date: Thu, 20 Sep 2018 00:10:35 +0200 Subject: Support link verification with redirects (#8735) (e.g. URL shortener) --- app/services/verify_link_service.rb | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) (limited to 'app/services/verify_link_service.rb') diff --git a/app/services/verify_link_service.rb b/app/services/verify_link_service.rb index 846751cd5..7d53bc255 100644 --- a/app/services/verify_link_service.rb +++ b/app/services/verify_link_service.rb @@ -27,6 +27,22 @@ class VerifyLinkService < BaseService def link_back_present? return false if @body.empty? - Nokogiri::HTML(@body).xpath('//a[contains(concat(" ", normalize-space(@rel), " "), " me ")]|//link[contains(concat(" ", normalize-space(@rel), " "), " me ")]').any? { |link| link['href'] == @link_back } + links = Nokogiri::HTML(@body).xpath('//a[contains(concat(" ", normalize-space(@rel), " "), " me ")]|//link[contains(concat(" ", normalize-space(@rel), " "), " me ")]') + + if links.any? { |link| link['href'] == @link_back } + true + elsif links.empty? + false + else + link_redirects_back?(links.first['href']) + end + end + + def link_redirects_back?(test_url) + redirect_to_url = Request.new(:head, test_url, follow: false).perform do |res| + res.headers['Location'] + end + + redirect_to_url == @link_back end end -- cgit