From c656cc2191479551806d288bdfb6a30aa35bcb23 Mon Sep 17 00:00:00 2001 From: ThibG Date: Thu, 21 Nov 2019 16:04:52 +0100 Subject: Fix FetchLinkCardServices crashing on a tags without a target (#12159) * Add test for links without targets * Fix FetchLinkCardServices crashing on a tags without a target --- app/services/fetch_link_card_service.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app/services') diff --git a/app/services/fetch_link_card_service.rb b/app/services/fetch_link_card_service.rb index 29880e8d8..5d4a7c303 100644 --- a/app/services/fetch_link_card_service.rb +++ b/app/services/fetch_link_card_service.rb @@ -67,7 +67,7 @@ class FetchLinkCardService < BaseService else html = Nokogiri::HTML(@status.text) links = html.css('a') - urls = links.map { |a| Addressable::URI.parse(a['href']).normalize unless skip_link?(a) }.compact + urls = links.map { |a| Addressable::URI.parse(a['href']) unless skip_link?(a) }.compact.map(&:normalize).compact end urls.reject { |uri| bad_url?(uri) }.first -- cgit