From 698684843748b9b847b8a6cf8cd2a30e3b507884 Mon Sep 17 00:00:00 2001 From: Eugen Rochko Date: Sat, 22 Jun 2019 16:54:06 +0200 Subject: port tootsuite#11151 to monsterfork: Fix audio-only OGG and WebM files not being processed as such Also, because Chrome sends audio/mp3 instead of audio/mpeg as it's supposed to, we need to whitelist that mime type as well --- app/models/concerns/attachmentable.rb | 11 +++++++++++ app/models/media_attachment.rb | 7 ++++++- 2 files changed, 17 insertions(+), 1 deletion(-) (limited to 'app') diff --git a/app/models/concerns/attachmentable.rb b/app/models/concerns/attachmentable.rb index 08af107c7..c3c7c7a35 100644 --- a/app/models/concerns/attachmentable.rb +++ b/app/models/concerns/attachmentable.rb @@ -11,10 +11,21 @@ module Attachmentable before_post_process :obfuscate_file_name before_post_process :set_file_extensions before_post_process :check_image_dimensions + before_post_process :set_file_content_type end private + def set_file_content_type + self.class.attachment_definitions.each_key do |attachment_name| + attachment = send(attachment_name) + + next if attachment.blank? || attachment.queued_for_write[:original].blank? + + attachment.instance_write :content_type, calculated_content_type(attachment) + end + end + def set_file_extensions self.class.attachment_definitions.each_key do |attachment_name| attachment = send(attachment_name) diff --git a/app/models/media_attachment.rb b/app/models/media_attachment.rb index 74f6c8899..4e57571d8 100644 --- a/app/models/media_attachment.rb +++ b/app/models/media_attachment.rb @@ -30,10 +30,15 @@ class MediaAttachment < ApplicationRecord VIDEO_FILE_EXTENSIONS = ['.webm', '.mp4', '.m4v', '.mov'].freeze AUDIO_FILE_EXTENSIONS = ['.ogg', '.oga', '.mp3', '.wav', '.flac', '.opus'].freeze +<<<<<<< HEAD IMAGE_MIME_TYPES = ['image/jpeg', 'image/png', 'image/gif'].freeze VIDEO_MIME_TYPES = ['video/webm', 'video/mp4', 'video/quicktime'].freeze +======= + IMAGE_MIME_TYPES = ['image/jpeg', 'image/png', 'image/gif', 'image/webp'].freeze + VIDEO_MIME_TYPES = ['video/webm', 'video/mp4', 'video/quicktime', 'video/ogg'].freeze +>>>>>>> b927bb3f0... Fix audio-only OGG and WebM files not being processed as such (#11151) VIDEO_CONVERTIBLE_MIME_TYPES = ['video/webm', 'video/quicktime'].freeze - AUDIO_MIME_TYPES = ['audio/wave', 'audio/wav', 'audio/x-wav', 'audio/x-pn-wave', 'audio/ogg', 'audio/mpeg', 'audio/webm', 'audio/flac'].freeze + AUDIO_MIME_TYPES = ['audio/wave', 'audio/wav', 'audio/x-wav', 'audio/x-pn-wave', 'audio/ogg', 'audio/mpeg', 'audio/mp3', 'audio/webm', 'audio/flac'].freeze BLURHASH_OPTIONS = { x_comp: 4, -- cgit