From b16b69350eb4ded2e1011931433b51dac5e34b53 Mon Sep 17 00:00:00 2001 From: unarist Date: Wed, 21 Jun 2017 01:45:09 +0900 Subject: Fix RTL detection on Ruby side (#3867) This fixes below bugs: * pipe characters being counted as RTL character * only first word being checked --- app/helpers/stream_entries_helper.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'app') diff --git a/app/helpers/stream_entries_helper.rb b/app/helpers/stream_entries_helper.rb index a17b02128..4ef7cffb0 100644 --- a/app/helpers/stream_entries_helper.rb +++ b/app/helpers/stream_entries_helper.rb @@ -53,11 +53,11 @@ module StreamEntriesHelper def rtl?(text) text = simplified_text(text) - rtl_characters = /[\p{Hebrew}|\p{Arabic}|\p{Syriac}|\p{Thaana}|\p{Nko}]+/m.match(text) + rtl_words = text.scan(/[\p{Hebrew}\p{Arabic}\p{Syriac}\p{Thaana}\p{Nko}]+/m) - if rtl_characters.present? + if rtl_words.present? total_size = text.size.to_f - rtl_size(rtl_characters.to_a) / total_size > 0.3 + rtl_size(rtl_words) / total_size > 0.3 else false end @@ -77,8 +77,8 @@ module StreamEntriesHelper end end - def rtl_size(characters) - characters.reduce(0) { |acc, elem| acc + elem.size }.to_f + def rtl_size(words) + words.reduce(0) { |acc, elem| acc + elem.size }.to_f end def embedded_view? -- cgit