From f48cb3eb170314cba1938522c0da44af21d47e83 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Sat, 29 Apr 2017 18:25:38 -0400 Subject: More coverage yes more even more (#2627) * Add coverage for admin/confirmations controller * Coverage for statuses controller show action * Add coverage for admin/domain_blocks controller * Add coverage for settings/profiles#update --- .../admin/confirmations_controller_spec.rb | 33 ++++++++++++++++++ .../admin/domain_blocks_controller_spec.rb | 40 ++++++++++++++++++++++ 2 files changed, 73 insertions(+) create mode 100644 spec/controllers/admin/confirmations_controller_spec.rb (limited to 'spec/controllers/admin') diff --git a/spec/controllers/admin/confirmations_controller_spec.rb b/spec/controllers/admin/confirmations_controller_spec.rb new file mode 100644 index 000000000..3f2b28c0e --- /dev/null +++ b/spec/controllers/admin/confirmations_controller_spec.rb @@ -0,0 +1,33 @@ +require 'rails_helper' + +RSpec.describe Admin::ConfirmationsController, type: :controller do + render_views + + before do + sign_in Fabricate(:user, admin: true), scope: :user + end + + describe 'POST #create' do + it 'confirms the user' do + account = Fabricate(:account) + user = Fabricate(:user, confirmed_at: false, account: account) + post :create, params: { account_id: account.id } + + expect(response).to redirect_to(admin_accounts_path) + expect(user.reload).to be_confirmed + end + + it 'raises an error when there is no account' do + post :create, params: { account_id: 'fake' } + + expect(response).to have_http_status(:missing) + end + + it 'raises an error when there is no user' do + account = Fabricate(:account, user: nil) + post :create, params: { account_id: account.id } + + expect(response).to have_http_status(:missing) + end + end +end diff --git a/spec/controllers/admin/domain_blocks_controller_spec.rb b/spec/controllers/admin/domain_blocks_controller_spec.rb index 4578efb02..0ca41d7d4 100644 --- a/spec/controllers/admin/domain_blocks_controller_spec.rb +++ b/spec/controllers/admin/domain_blocks_controller_spec.rb @@ -10,7 +10,47 @@ RSpec.describe Admin::DomainBlocksController, type: :controller do describe 'GET #index' do it 'returns http success' do get :index + expect(response).to have_http_status(:success) end end + + describe 'GET #new' do + it 'returns http success' do + get :new + + expect(response).to have_http_status(:success) + end + end + + describe 'GET #show' do + it 'returns http success' do + domain_block = Fabricate(:domain_block) + get :show, params: { id: domain_block.id } + + expect(response).to have_http_status(:success) + end + end + + describe 'POST #create' do + it 'blocks the domain' do + allow(DomainBlockWorker).to receive(:perform_async).and_return(true) + post :create, params: { domain_block: { domain: 'example.com', severity: 'silence' } } + + expect(DomainBlockWorker).to have_received(:perform_async) + expect(response).to redirect_to(admin_domain_blocks_path) + end + end + + describe 'DELETE #destroy' do + it 'unblocks the domain' do + service = double(call: true) + allow(UnblockDomainService).to receive(:new).and_return(service) + domain_block = Fabricate(:domain_block) + delete :destroy, params: { id: domain_block.id, domain_block: { retroactive: '1' } } + + expect(service).to have_received(:call).with(domain_block, true) + expect(response).to redirect_to(admin_domain_blocks_path) + end + end end -- cgit