From 66fd8e782182390df81f1ed46f3a04f3a01d681e Mon Sep 17 00:00:00 2001 From: Evan Minto Date: Sat, 22 Apr 2017 20:21:10 -0700 Subject: ActivityPub: Add basic, read-only support for Outboxes, Notes, and Create/Announce Activities (#2197) * Clean up collapsible components * Expose user Outboxes and AS2 representations of statuses * Save work thus far. * Fix bad merge. * Save my work * Clean up pagination. * First test working. * Add tests. * Add Forbidden error template. * Revert yarn.lock changes. * Fix code style deviations and use localized instead of hardcoded English text. --- .../api/activitypub/activities_controller_spec.rb | 77 ++++++++++++++++++ .../api/activitypub/notes_controller_spec.rb | 81 +++++++++++++++++++ .../api/activitypub/outbox_controller_spec.rb | 92 ++++++++++++++++++++++ 3 files changed, 250 insertions(+) create mode 100644 spec/controllers/api/activitypub/activities_controller_spec.rb create mode 100644 spec/controllers/api/activitypub/notes_controller_spec.rb create mode 100644 spec/controllers/api/activitypub/outbox_controller_spec.rb (limited to 'spec/controllers/api') diff --git a/spec/controllers/api/activitypub/activities_controller_spec.rb b/spec/controllers/api/activitypub/activities_controller_spec.rb new file mode 100644 index 000000000..c78c93a75 --- /dev/null +++ b/spec/controllers/api/activitypub/activities_controller_spec.rb @@ -0,0 +1,77 @@ +require 'rails_helper' + +RSpec.describe Api::Activitypub::ActivitiesController, type: :controller do + render_views + + let(:user) { Fabricate(:user, account: Fabricate(:account, username: 'alice')) } + + describe 'GET #show' do + describe 'normal status' do + public_status = nil + + before do + public_status = Status.create!(account: user.account, text: 'Hello world', visibility: :public) + + @request.env['HTTP_ACCEPT'] = 'application/activity+json' + get :show_status, id: public_status.id + end + + it 'returns http success' do + expect(response).to have_http_status(:success) + end + + it 'sets Content-Type header to AS2' do + expect(response.header['Content-Type']).to include 'application/activity+json' + end + + it 'sets Access-Control-Allow-Origin header to *' do + expect(response.header['Access-Control-Allow-Origin']).to eq '*' + end + + it 'returns http success' do + json_data = JSON.parse(response.body) + expect(json_data).to include('@context' => 'https://www.w3.org/ns/activitystreams') + expect(json_data).to include('type' => 'Create') + expect(json_data).to include('id' => @request.url) + expect(json_data).to include('type' => 'Create') + expect(json_data).to include('object' => api_activitypub_note_url(public_status)) + expect(json_data).to include('url' => TagManager.instance.url_for(public_status)) + end + end + + describe 'reblog' do + original = nil + reblog = nil + + before do + original = Status.create!(account: user.account, text: 'Hello world', visibility: :public) + reblog = Status.create!(account: user.account, reblog_of_id: original.id, visibility: :public) + + @request.env['HTTP_ACCEPT'] = 'application/activity+json' + get :show_status, id: reblog.id + end + + it 'returns http success' do + expect(response).to have_http_status(:success) + end + + it 'sets Content-Type header to AS2' do + expect(response.header['Content-Type']).to include 'application/activity+json' + end + + it 'sets Access-Control-Allow-Origin header to *' do + expect(response.header['Access-Control-Allow-Origin']).to eq '*' + end + + it 'returns http success' do + json_data = JSON.parse(response.body) + expect(json_data).to include('@context' => 'https://www.w3.org/ns/activitystreams') + expect(json_data).to include('type' => 'Announce') + expect(json_data).to include('id' => @request.url) + expect(json_data).to include('type' => 'Announce') + expect(json_data).to include('object' => api_activitypub_status_url(original)) + expect(json_data).to include('url' => TagManager.instance.url_for(reblog)) + end + end + end +end diff --git a/spec/controllers/api/activitypub/notes_controller_spec.rb b/spec/controllers/api/activitypub/notes_controller_spec.rb new file mode 100644 index 000000000..df8f1b42a --- /dev/null +++ b/spec/controllers/api/activitypub/notes_controller_spec.rb @@ -0,0 +1,81 @@ +require 'rails_helper' + +RSpec.describe Api::Activitypub::NotesController, type: :controller do + render_views + + let(:user_alice) { Fabricate(:user, account: Fabricate(:account, username: 'alice')) } + let(:user_bob) { Fabricate(:user, account: Fabricate(:account, username: 'bob')) } + + describe 'GET #show' do + describe 'normal status' do + public_status = nil + + before do + public_status = Status.create!(account: user_alice.account, text: 'Hello world', visibility: :public) + + @request.env['HTTP_ACCEPT'] = 'application/activity+json' + get :show, id: public_status.id + end + + it 'returns http success' do + expect(response).to have_http_status(:success) + end + + it 'sets Content-Type header to AS2' do + expect(response.header['Content-Type']).to include 'application/activity+json' + end + + it 'sets Access-Control-Allow-Origin header to *' do + expect(response.header['Access-Control-Allow-Origin']).to eq '*' + end + + it 'returns http success' do + json_data = JSON.parse(response.body) + expect(json_data).to include('@context' => 'https://www.w3.org/ns/activitystreams') + expect(json_data).to include('type' => 'Note') + expect(json_data).to include('id' => @request.url) + expect(json_data).to include('name' => 'Hello world') + expect(json_data).to include('content' => 'Hello world') + expect(json_data).to include('published') + expect(json_data).to include('url' => TagManager.instance.url_for(public_status)) + end + end + + describe 'reply' do + original = nil + reply = nil + + before do + original = Status.create!(account: user_alice.account, text: 'Hello world', visibility: :public) + reply = Status.create!(account: user_bob.account, text: 'Hello world', in_reply_to_id: original.id, visibility: :public) + + @request.env['HTTP_ACCEPT'] = 'application/activity+json' + get :show, id: reply.id + end + + it 'returns http success' do + expect(response).to have_http_status(:success) + end + + it 'sets Content-Type header to AS2' do + expect(response.header['Content-Type']).to include 'application/activity+json' + end + + it 'sets Access-Control-Allow-Origin header to *' do + expect(response.header['Access-Control-Allow-Origin']).to eq '*' + end + + it 'returns http success' do + json_data = JSON.parse(response.body) + expect(json_data).to include('@context' => 'https://www.w3.org/ns/activitystreams') + expect(json_data).to include('type' => 'Note') + expect(json_data).to include('id' => @request.url) + expect(json_data).to include('name' => 'Hello world') + expect(json_data).to include('content' => 'Hello world') + expect(json_data).to include('published') + expect(json_data).to include('url' => TagManager.instance.url_for(reply)) + expect(json_data).to include('inReplyTo' => api_activitypub_note_url(original)) + end + end + end +end diff --git a/spec/controllers/api/activitypub/outbox_controller_spec.rb b/spec/controllers/api/activitypub/outbox_controller_spec.rb new file mode 100644 index 000000000..55fb9b509 --- /dev/null +++ b/spec/controllers/api/activitypub/outbox_controller_spec.rb @@ -0,0 +1,92 @@ +require 'rails_helper' + +RSpec.describe Api::Activitypub::OutboxController, type: :controller do + render_views + + let(:user) { Fabricate(:user, account: Fabricate(:account, username: 'alice')) } + + describe 'GET #show' do + before do + @request.env['HTTP_ACCEPT'] = 'application/activity+json' + end + + describe 'small number of statuses' do + public_status = nil + + before do + public_status = Status.create!(account: user.account, text: 'Hello world', visibility: :public) + Status.create!(account: user.account, text: 'Hello world', visibility: :private) + Status.create!(account: user.account, text: 'Hello world', visibility: :unlisted) + Status.create!(account: user.account, text: 'Hello world', visibility: :direct) + + get :show, id: user.account.id + end + + it 'returns http success' do + expect(response).to have_http_status(:success) + end + + it 'sets Content-Type header to AS2' do + expect(response.header['Content-Type']).to include 'application/activity+json' + end + + it 'sets Access-Control-Allow-Origin header to *' do + expect(response.header['Access-Control-Allow-Origin']).to eq '*' + end + + it 'returns AS2 JSON body' do + json_data = JSON.parse(response.body) + expect(json_data).to include('@context' => 'https://www.w3.org/ns/activitystreams') + expect(json_data).to include('id' => @request.url) + expect(json_data).to include('type' => 'OrderedCollection') + expect(json_data).to include('totalItems' => 1) + expect(json_data).to include('items') + expect(json_data['items'].count).to eq(1) + expect(json_data['items']).to include(api_activitypub_status_url(public_status)) + end + end + + describe 'large number of statuses' do + before do + 30.times do + Status.create!(account: user.account, text: 'Hello world', visibility: :public) + end + + Status.create!(account: user.account, text: 'Hello world', visibility: :private) + Status.create!(account: user.account, text: 'Hello world', visibility: :unlisted) + Status.create!(account: user.account, text: 'Hello world', visibility: :direct) + end + + describe 'first page' do + before do + get :show, id: user.account.id + end + + it 'returns http success' do + expect(response).to have_http_status(:success) + end + + it 'sets Content-Type header to AS2' do + expect(response.header['Content-Type']).to include 'application/activity+json' + end + + it 'sets Access-Control-Allow-Origin header to *' do + expect(response.header['Access-Control-Allow-Origin']).to eq '*' + end + + it 'returns AS2 JSON body' do + json_data = JSON.parse(response.body) + expect(json_data).to include('@context' => 'https://www.w3.org/ns/activitystreams') + expect(json_data).to include('id' => @request.url) + expect(json_data).to include('type' => 'OrderedCollectionPage') + expect(json_data).to include('totalItems' => 20) + expect(json_data).to include('items') + expect(json_data['items'].count).to eq(20) + expect(json_data).to include('current' => @request.url) + expect(json_data).to include('next') + expect(json_data).to_not include('prev') + end + end + end + end +end -- cgit