From 8c5ad23b24b17efc0660928d0b02ddbebc6f2939 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Wed, 3 May 2017 10:59:31 -0400 Subject: Language improvements, replace whatlanguage with CLD (#2753) * add failing en specs * add cld2 gem * Replace WhatLanguage with CLD --- spec/lib/language_detector_spec.rb | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) (limited to 'spec') diff --git a/spec/lib/language_detector_spec.rb b/spec/lib/language_detector_spec.rb index 5fb19a1e7..bd4e65ef8 100644 --- a/spec/lib/language_detector_spec.rb +++ b/spec/lib/language_detector_spec.rb @@ -3,11 +3,17 @@ require 'rails_helper' describe LanguageDetector do describe 'to_iso_s' do - it 'detects english language' do - string = 'Hello and welcome to mastodon' - result = described_class.new(string).to_iso_s - - expect(result).to eq :en + it 'detects english language for basic strings' do + strings = [ + "Hello and welcome to mastodon", + "I'd rather not!", + "a lot of people just want to feel righteous all the time and that's all that matters", + ] + strings.each do |string| + result = described_class.new(string).to_iso_s + + expect(result).to eq(:en), string + end end it 'detects spanish language' do @@ -19,15 +25,15 @@ describe LanguageDetector do describe 'when language can\'t be detected' do it 'confirm language engine cant detect' do - result = WhatLanguage.new(:all).language_iso('') - expect(result).to be_nil + result = CLD.detect_language('') + expect(result[:reliable]).to be false end describe 'because of a URL' do it 'uses default locale when sent just a URL' do string = 'http://example.com/media/2kFTgOJLXhQf0g2nKB4' - wl_result = WhatLanguage.new(:all).language_iso(string) - expect(wl_result).not_to eq :en + cld_result = CLD.detect_language(string)[:code] + expect(cld_result).not_to eq :en result = described_class.new(string).to_iso_s -- cgit