From b5a9c6b3d292abc7e47d8a6f830f6b5589c04862 Mon Sep 17 00:00:00 2001 From: Eugen Rochko Date: Fri, 12 May 2017 17:46:44 +0200 Subject: Prepend reblogs' wrapper content with "RT @original_author", (#3013) so that when a reblog parse fails on another instance, it doesn't look like a misattributed/stolen text --- spec/lib/formatter_spec.rb | 75 ++++++++++++++++++++++++++++++++-------------- 1 file changed, 52 insertions(+), 23 deletions(-) (limited to 'spec') diff --git a/spec/lib/formatter_spec.rb b/spec/lib/formatter_spec.rb index 15b4e1d96..1db7f0bc9 100644 --- a/spec/lib/formatter_spec.rb +++ b/spec/lib/formatter_spec.rb @@ -7,38 +7,56 @@ RSpec.describe Formatter do let(:remote_status) { Fabricate(:status, text: ' Beep boop', uri: 'beepboop', account: account) } let(:local_text_with_mention) { "@#{account.username} @#{account.username}@example.com #{local_text}?x=@#{account.username} #hashtag" } - let(:local_status_with_mention) { Fabricate(:status, text: local_text_with_mention, - account: account, mentions: [Fabricate(:mention, account: account)]) } + + let(:local_status_with_mention) do + Fabricate( + :status, + text: local_text_with_mention, + account: account, + mentions: [Fabricate(:mention, account: account)] + ) + end describe '#format' do subject { Formatter.instance.format(local_status) } - it 'returns a string' do - expect(subject).to be_a String - end + context 'with standalone status' do + it 'returns a string' do + expect(subject).to be_a String + end - it 'contains plain text' do - expect(subject).to match('Hello world') - end + it 'contains plain text' do + expect(subject).to match('Hello world') + end - it 'contains a link' do - expect(subject).to match('google.com/') - end + it 'contains a link' do + expect(subject).to match('google.com/') + end - it 'contains a mention' do - result = Formatter.instance.format(local_status_with_mention) - expect(result).to match "@#{account.username}" - expect(result).to match %r{href=\"http://google.com/\?x=@#{account.username}} - expect(result).not_to match "href=\"https://example.com/@#{account.username}" + it 'contains a mention' do + result = Formatter.instance.format(local_status_with_mention) + expect(result).to match "@#{account.username}" + expect(result).to match %r{href=\"http://google.com/\?x=@#{account.username}} + expect(result).not_to match "href=\"https://example.com/@#{account.username}" + end + + it 'contains a hashtag' do + result = Formatter.instance.format(local_status_with_mention) + expect(result).to match('/tags/hashtag" class="mention hashtag" rel="tag">#hashtag') + end end - it 'contains a hashtag' do - result = Formatter.instance.format(local_status_with_mention) - expect(result).to match("/tags/hashtag\" class=\"mention hashtag\">#hashtag") + context 'with reblog' do + let(:local_status) { Fabricate(:status, account: account, reblog: Fabricate(:status, text: 'Hello world', account: account)) } + + it 'contains credit to original author' do + expect(subject).to include("RT @#{account.username} Hello world") + end end context 'matches a stand-alone medium URL' do let(:local_text) { 'https://hackernoon.com/the-power-to-build-communities-a-response-to-mark-zuckerberg-3f2cac9148a4' } + it 'has valid url' do expect(subject).to include('href="https://hackernoon.com/the-power-to-build-communities-a-response-to-mark-zuckerberg-3f2cac9148a4"') end @@ -46,6 +64,7 @@ RSpec.describe Formatter do context 'matches a stand-alone google URL' do let(:local_text) { 'http://google.com' } + it 'has valid url' do expect(subject).to include('href="http://google.com/"') end @@ -53,6 +72,7 @@ RSpec.describe Formatter do context 'matches a stand-alone IDN URL' do let(:local_text) { 'https://nic.みんな/' } + it 'has valid url' do expect(subject).to include('href="https://nic.xn--q9jyb4c/"') end @@ -64,6 +84,7 @@ RSpec.describe Formatter do context 'matches a URL without trailing period' do let(:local_text) { 'http://www.mcmansionhell.com/post/156408871451/50-states-of-mcmansion-hell-scottsdale-arizona. ' } + it 'has valid url' do expect(subject).to include('href="http://www.mcmansionhell.com/post/156408871451/50-states-of-mcmansion-hell-scottsdale-arizona"') end @@ -75,6 +96,7 @@ RSpec.describe Formatter do context 'matches a URL without exclamation point' do let(:local_text) { 'http://www.google.com!' } + it 'has valid url' do expect(subject).to include('href="http://www.google.com/"') end @@ -82,6 +104,7 @@ RSpec.describe Formatter do context 'matches a URL without single quote' do let(:local_text) { "http://www.google.com'" } + it 'has valid url' do expect(subject).to include('href="http://www.google.com/"') end @@ -89,6 +112,7 @@ RSpec.describe Formatter do context 'matches a URL without angle brackets' do let(:local_text) { 'http://www.google.com>' } + it 'has valid url' do expect(subject).to include('href="http://www.google.com/"') end @@ -96,6 +120,7 @@ RSpec.describe Formatter do context 'matches a URL with a query string' do let(:local_text) { 'https://www.ruby-toolbox.com/search?utf8=%E2%9C%93&q=autolink' } + it 'has valid url' do expect(subject).to include('href="https://www.ruby-toolbox.com/search?utf8=%E2%9C%93&q=autolink"') end @@ -103,20 +128,23 @@ RSpec.describe Formatter do context 'matches a URL with parenthesis in it' do let(:local_text) { 'https://en.wikipedia.org/wiki/Diaspora_(software)' } + it 'has valid url' do expect(subject).to include('href="https://en.wikipedia.org/wiki/Diaspora_(software)"') end end context 'contains html (script tag)' do - let(:local_text) { '' } - it 'has valid url' do - expect(subject).to match '

<script>alert("Hello")</script>

' - end + let(:local_text) { '' } + + it 'has valid url' do + expect(subject).to match '

<script>alert("Hello")</script>

' + end end context 'contains html (xss attack)' do let(:local_text) { %q{} } + it 'has valid url' do expect(subject).to match '

<img src="javascript:alert('XSS');">

' end @@ -124,6 +152,7 @@ RSpec.describe Formatter do context 'contains invalid URL' do let(:local_text) { 'http://www\.google\.com' } + it 'has valid url' do expect(subject).to eq '

http://www\.google\.com

' end -- cgit