about summary refs log tree commit diff
diff options
context:
space:
mode:
authorEugen Rochko <eugen@zeonfederated.com>2016-11-18 23:16:34 +0100
committerEugen Rochko <eugen@zeonfederated.com>2016-11-18 23:16:34 +0100
commite4f56fa94217061b25f3a8f45d17c8657ca9c56d (patch)
tree37fa33ecf00febc7f909fa97d2d5dc6744a7e994
parent882de42bab197e4d6b7b8acf327e72a240eda76d (diff)
Don't create attachments if remote file cannot be fetched
-rw-r--r--app/models/media_attachment.rb2
-rw-r--r--app/services/process_feed_service.rb2
2 files changed, 1 insertions, 3 deletions
diff --git a/app/models/media_attachment.rb b/app/models/media_attachment.rb
index d3e3d73be..bfbf00d76 100644
--- a/app/models/media_attachment.rb
+++ b/app/models/media_attachment.rb
@@ -22,8 +22,6 @@ class MediaAttachment < ApplicationRecord
 
   def file_remote_url=(url)
     self.file = URI.parse(url)
-  rescue OpenURI::HTTPError => e
-    Rails.logger.debug "Error fetching remote attachment: #{e}"
   end
 
   def image?
diff --git a/app/services/process_feed_service.rb b/app/services/process_feed_service.rb
index 561feb032..08c66c904 100644
--- a/app/services/process_feed_service.rb
+++ b/app/services/process_feed_service.rb
@@ -173,7 +173,7 @@ class ProcessFeedService < BaseService
         begin
           media.file_remote_url = link['href']
           media.save
-        rescue Paperclip::Errors::NotIdentifiedByImageMagickError
+        rescue OpenURI::HTTPError, Paperclip::Errors::NotIdentifiedByImageMagickError
           next
         end
       end