diff options
| author | ThibG <thib@sitedethib.com> | 2017-06-11 22:53:12 +0200 |
|---|---|---|
| committer | Eugen Rochko <eugen@zeonfederated.com> | 2017-06-11 22:53:12 +0200 |
| commit | f8fe394e7a03edacb06c336b3990d6e488336361 (patch) | |
| tree | d3a4fe5d18cb16dd826230d80f7fb17edc124e83 | |
| parent | 2a545e0fb1d424270f79b01288f7436c4ff347ad (diff) | |
Fix an error when TagManager.local_url? is called with a bad URI (#3701)
TagManager.local_url? was sometimes called with an URI with a nil host, leading to a crash in TagManager.local_url?. This fixes moves the already-existing uri.host.blank? check in front to avoid this case.
| -rw-r--r-- | app/services/fetch_link_card_service.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/fetch_link_card_service.rb b/app/services/fetch_link_card_service.rb index ec9b5226e..c2df7b2f0 100644 --- a/app/services/fetch_link_card_service.rb +++ b/app/services/fetch_link_card_service.rb @@ -36,7 +36,7 @@ class FetchLinkCardService < BaseService def bad_url?(uri) # Avoid local instance URLs and invalid URLs - TagManager.instance.local_url?(uri.to_s) || !%w(http https).include?(uri.scheme) || uri.host.blank? + uri.host.blank? || TagManager.instance.local_url?(uri.to_s) || !%w(http https).include?(uri.scheme) end def skip_link?(a) |