about summary refs log tree commit diff
diff options
context:
space:
mode:
authorNolan Lawson <nolan@nolanlawson.com>2017-06-30 04:43:26 -0700
committerEugen Rochko <eugen@zeonfederated.com>2017-06-30 13:43:26 +0200
commit968354923ec5063946d561e41194870ce37ec43a (patch)
treeb2d2a1bdfec3bb45e7458f835957c3550cac0ff9
parent59ddf81a4533044452bd7e6a25dd4469cc660ffb (diff)
Fix webpack-dev-server on Windows (#4000)
* Fix webpack-dev-server on Windows

* Serve webpack from 0.0.0.0, access at 127.0.0.1
-rwxr-xr-xbin/webpack-dev-server2
-rw-r--r--config/webpacker.yml2
2 files changed, 2 insertions, 2 deletions
diff --git a/bin/webpack-dev-server b/bin/webpack-dev-server
index a867f2c01..0beec3175 100755
--- a/bin/webpack-dev-server
+++ b/bin/webpack-dev-server
@@ -23,7 +23,7 @@ end
 begin
   dev_server = YAML.load_file(CONFIG_FILE)["development"]["dev_server"]
 
-  DEV_SERVER_HOST = "http#{"s" if args('--https') || dev_server["https"]}://#{args('--host') || dev_server["host"]}:#{args('--port') || dev_server["port"]}"
+  DEV_SERVER_HOST = "http#{"s" if args('--https') || dev_server["https"]}://#{dev_server["host"]}:#{args('--port') || dev_server["port"]}"
 
 rescue Errno::ENOENT, NoMethodError
   puts "Webpack dev_server configuration not found in #{CONFIG_FILE}."
diff --git a/config/webpacker.yml b/config/webpacker.yml
index c1cd6e93b..aa429a1dd 100644
--- a/config/webpacker.yml
+++ b/config/webpacker.yml
@@ -19,7 +19,7 @@ development:
   <<: *default
 
   dev_server:
-    host: 0.0.0.0
+    host: 127.0.0.1
     port: 8080
     https: false