diff options
author | Thibaut Girka <thib@sitedethib.com> | 2018-03-28 17:13:13 +0200 |
---|---|---|
committer | Thibaut Girka <thib@sitedethib.com> | 2018-04-22 19:17:10 +0200 |
commit | 259bc9840b061fa466b203035b2941efd5a8907f (patch) | |
tree | 22ba2c118d686acc637c3819c7e8627d6a1dae30 | |
parent | 63d671b18f010d5f60421b0bd2acd8eeff45169d (diff) |
[Glitch] Fix style of legacy column headers
Backports daefbd66a653b11a17be73b7b0a4ca200b466cec
-rw-r--r-- | app/javascript/flavours/glitch/features/ui/components/column_header.js | 20 |
1 files changed, 11 insertions, 9 deletions
diff --git a/app/javascript/flavours/glitch/features/ui/components/column_header.js b/app/javascript/flavours/glitch/features/ui/components/column_header.js index af195ea9c..e8bdd8054 100644 --- a/app/javascript/flavours/glitch/features/ui/components/column_header.js +++ b/app/javascript/flavours/glitch/features/ui/components/column_header.js @@ -1,5 +1,6 @@ import React from 'react'; import PropTypes from 'prop-types'; +import classNames from 'classnames'; export default class ColumnHeader extends React.PureComponent { @@ -16,19 +17,20 @@ export default class ColumnHeader extends React.PureComponent { } render () { - const { type, active, columnHeaderId } = this.props; + const { icon, type, active, columnHeaderId } = this.props; + let iconElement = ''; - let icon = ''; - - if (this.props.icon) { - icon = <i className={`fa fa-fw fa-${this.props.icon} column-header__icon`} />; + if (icon) { + iconElement = <i className={`fa fa-fw fa-${icon} column-header__icon`} />; } return ( - <div role='heading' tabIndex='0' className={`column-header ${active ? 'active' : ''}`} onClick={this.handleClick} id={columnHeaderId || null}> - {icon} - {type} - </div> + <h1 className={classNames('column-header', { active })} id={columnHeaderId || null}> + <button onClick={this.handleClick}> + {iconElement} + {type} + </button> + </h1> ); } |