about summary refs log tree commit diff
diff options
context:
space:
mode:
authorkawaguchi <jiikko@users.noreply.github.com>2020-09-17 03:16:46 +0900
committerGitHub <noreply@github.com>2020-09-16 20:16:46 +0200
commit5d3c8baa9a0aa42c68cf0485c187652a435891ab (patch)
tree66747a803c1569c50a9dce8b5e01006aae319fab
parent9b74f6aca6aa3d130895c4737d1fa1db4fcffb5c (diff)
Fix validates :sign_count of WebauthnCredential (#14806)
-rw-r--r--app/models/webauthn_credential.rb2
-rw-r--r--spec/models/webauthn_credentials_spec.rb4
2 files changed, 3 insertions, 3 deletions
diff --git a/app/models/webauthn_credential.rb b/app/models/webauthn_credential.rb
index 4129ce539..7d423e38d 100644
--- a/app/models/webauthn_credential.rb
+++ b/app/models/webauthn_credential.rb
@@ -18,5 +18,5 @@ class WebauthnCredential < ApplicationRecord
   validates :external_id, uniqueness: true
   validates :nickname, uniqueness: { scope: :user_id }
   validates :sign_count,
-            numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: 2**32 - 1 }
+            numericality: { only_integer: true, greater_than_or_equal_to: 0, less_than_or_equal_to: 2**63 - 1 }
 end
diff --git a/spec/models/webauthn_credentials_spec.rb b/spec/models/webauthn_credentials_spec.rb
index 9289c371e..a63ae6cd2 100644
--- a/spec/models/webauthn_credentials_spec.rb
+++ b/spec/models/webauthn_credentials_spec.rb
@@ -69,8 +69,8 @@ RSpec.describe WebauthnCredential, type: :model do
       expect(webauthn_credential).to model_have_error_on_field(:sign_count)
     end
 
-    it 'is invalid if sign_count is greater 2**32 - 1' do
-      webauthn_credential = Fabricate.build(:webauthn_credential, sign_count: 2**32)
+    it 'is invalid if sign_count is greater 2**63 - 1' do
+      webauthn_credential = Fabricate.build(:webauthn_credential, sign_count: 2**63)
 
       webauthn_credential.valid?