about summary refs log tree commit diff
diff options
context:
space:
mode:
authorYamagishi Kazutoshi <ykzts@desire.sh>2020-05-04 01:48:13 +0900
committerGitHub <noreply@github.com>2020-05-03 18:48:13 +0200
commite223fd8c6190661237ea43e7773e47513c48fd46 (patch)
tree58a36002976831ddf2cf99616a01859e2440ef0b
parent988b0493fea7a850130b83d0e81675bda8dd9d8e (diff)
Revert "improve status title (#8596)" (#13591)
This reverts commit 05756c9a14864655ae6777505a4ee5cfa9b0ee93.
-rw-r--r--app/models/status.rb6
-rw-r--r--spec/models/status_spec.rb12
2 files changed, 5 insertions, 13 deletions
diff --git a/app/models/status.rb b/app/models/status.rb
index 30f86e664..a938ff032 100644
--- a/app/models/status.rb
+++ b/app/models/status.rb
@@ -200,12 +200,8 @@ class Status < ApplicationRecord
   def title
     if destroyed?
       "#{account.acct} deleted status"
-    elsif reblog?
-      preview = sensitive ? '<sensitive>' : text.slice(0, 10).split("\n")[0]
-      "#{account.acct} shared #{reblog.account.acct}'s: #{preview}"
     else
-      preview = sensitive ? '<sensitive>' : text.slice(0, 20).split("\n")[0]
-      "#{account.acct}: #{preview}"
+      reblog? ? "#{account.acct} shared a status by #{reblog.account.acct}" : "New status by #{account.acct}"
     end
   end
 
diff --git a/spec/models/status_spec.rb b/spec/models/status_spec.rb
index b238691a8..51a10cd17 100644
--- a/spec/models/status_spec.rb
+++ b/spec/models/status_spec.rb
@@ -96,20 +96,16 @@ RSpec.describe Status, type: :model do
 
     context 'unless destroyed?' do
       context 'if reblog?' do
-        it 'returns "#{account.acct} shared #{reblog.account.acct}\'s: #{preview}"' do
+        it 'returns "#{account.acct} shared a status by #{reblog.account.acct}"' do
           reblog = subject.reblog = other
-          preview = subject.text.slice(0, 10).split("\n")[0]
-          expect(subject.title).to(
-            eq "#{account.acct} shared #{reblog.account.acct}'s: #{preview}"
-          )
+          expect(subject.title).to eq "#{account.acct} shared a status by #{reblog.account.acct}"
         end
       end
 
       context 'unless reblog?' do
-        it 'returns "#{account.acct}: #{preview}"' do
+        it 'returns "New status by #{account.acct}"' do
           subject.reblog = nil
-          preview = subject.text.slice(0, 20).split("\n")[0]
-          expect(subject.title).to eq "#{account.acct}: #{preview}"
+          expect(subject.title).to eq "New status by #{account.acct}"
         end
       end
     end