diff options
author | Yamagishi Kazutoshi <ykzts@desire.sh> | 2017-04-22 03:05:35 +0900 |
---|---|---|
committer | Eugen <eugen@zeonfederated.com> | 2017-04-21 20:05:35 +0200 |
commit | 1948f9e767c5c8f7cb52337ce777a61b5ad1a599 (patch) | |
tree | 4d5f3549f6e5fd88340bb3543e1eb2eafc47952c /app/assets/javascripts/components/features/notifications/index.jsx | |
parent | 27ea2a88c12835b491ea5537f934983470faf781 (diff) |
Remove deprecated features at React v15.5 (#1905)
* Remove deprecated features at React v15.5 - [x] React.PropTypes - [x] react-addons-pure-render-mixin - [x] react-addons-test-utils * Uncommented out & Add browserify_rails options * re-add react-addons-shallow * Fix syntax error from resolve conflicts * follow up 59a77923b368d48c590cd9f4a0c6b73ce972d33f
Diffstat (limited to 'app/assets/javascripts/components/features/notifications/index.jsx')
-rw-r--r-- | app/assets/javascripts/components/features/notifications/index.jsx | 52 |
1 files changed, 28 insertions, 24 deletions
diff --git a/app/assets/javascripts/components/features/notifications/index.jsx b/app/assets/javascripts/components/features/notifications/index.jsx index 74b914ffd..7b9b6d9e4 100644 --- a/app/assets/javascripts/components/features/notifications/index.jsx +++ b/app/assets/javascripts/components/features/notifications/index.jsx @@ -1,5 +1,5 @@ import { connect } from 'react-redux'; -import PureRenderMixin from 'react-addons-pure-render-mixin'; +import PropTypes from 'prop-types'; import ImmutablePropTypes from 'react-immutable-proptypes'; import Column from '../ui/components/column'; import { expandNotifications, clearNotifications, scrollTopNotifications } from '../../actions/notifications'; @@ -28,24 +28,15 @@ const mapStateToProps = state => ({ isUnread: state.getIn(['notifications', 'unread']) > 0 }); -const Notifications = React.createClass({ +class Notifications extends React.PureComponent { - propTypes: { - notifications: ImmutablePropTypes.list.isRequired, - dispatch: React.PropTypes.func.isRequired, - trackScroll: React.PropTypes.bool, - intl: React.PropTypes.object.isRequired, - isLoading: React.PropTypes.bool, - isUnread: React.PropTypes.bool - }, - - getDefaultProps () { - return { - trackScroll: true - }; - }, - - mixins: [PureRenderMixin], + constructor (props, context) { + super(props, context); + this.handleScroll = this.handleScroll.bind(this); + this.handleLoadMore = this.handleLoadMore.bind(this); + this.handleClear = this.handleClear.bind(this); + this.setRef = this.setRef.bind(this); + } handleScroll (e) { const { scrollTop, scrollHeight, clientHeight } = e.target; @@ -59,28 +50,28 @@ const Notifications = React.createClass({ } else { this.props.dispatch(scrollTopNotifications(false)); } - }, + } componentDidUpdate (prevProps) { if (this.node.scrollTop > 0 && (prevProps.notifications.size < this.props.notifications.size && prevProps.notifications.first() !== this.props.notifications.first() && !!this._oldScrollPosition)) { this.node.scrollTop = this.node.scrollHeight - this._oldScrollPosition; } - }, + } handleLoadMore (e) { e.preventDefault(); this.props.dispatch(expandNotifications()); - }, + } handleClear () { if (window.confirm(this.props.intl.formatMessage(messages.confirm))) { this.props.dispatch(clearNotifications()); } - }, + } setRef (c) { this.node = c; - }, + } render () { const { intl, notifications, trackScroll, isLoading, isUnread } = this.props; @@ -137,6 +128,19 @@ const Notifications = React.createClass({ } } -}); +} + +Notifications.propTypes = { + notifications: ImmutablePropTypes.list.isRequired, + dispatch: PropTypes.func.isRequired, + trackScroll: PropTypes.bool, + intl: PropTypes.object.isRequired, + isLoading: PropTypes.bool, + isUnread: PropTypes.bool +}; + +Notifications.defaultProps = { + trackScroll: true +}; export default connect(mapStateToProps)(injectIntl(Notifications)); |