about summary refs log tree commit diff
path: root/app/helpers
diff options
context:
space:
mode:
authorStephen Burgess <stephenburgess8@gmail.com>2017-04-22 10:30:35 -0500
committerEugen <eugen@zeonfederated.com>2017-04-22 17:30:35 +0200
commit4cfc15556016c886aa0f385ea664680647e31aca (patch)
tree918b102b44698e6c847540eddbd1c31b519ef660 /app/helpers
parenta1174a6d7e60dd73ab97da08b52dd751c45e2b6b (diff)
Improve aria support - Columns and Navigation Drawer Icons (#2299)
* feat(aria): Add aria-labels to underlabelled tab nav items

The drawer tabs which control primary navigation are only labelled by a title which is not available to many screenreaders. Add an aria-label attribute to each link to improve readability with screenreaders. Organize link attributes so link target is first followed by classname.
Issue #1349

* feat(aria): Replace abstract aria role of section with region

Abstract aria roles such as section should not be used in content. Use non-abstract 'region' aria role instead. That role expects an aria-labelledby attribute with an id. Pass an ID to the column header. Remove the aria-label attribute on the ColumnHeader because the same value is output in plaintext as its child.
Issue #1349

* fix(aria): Remove aria-controls attribute until solution is found

Columns do not have wrappers, so these icons can't point to a column wrapper which it controls. Instead these icons function as triggers to show or hide individual columns.
#1349

* fix(typo): Remove type of aria-labelledby instead of aria-label
Diffstat (limited to 'app/helpers')
0 files changed, 0 insertions, 0 deletions