about summary refs log tree commit diff
path: root/app/lib/activitypub/activity/like.rb
diff options
context:
space:
mode:
authorEugen Rochko <eugen@zeonfederated.com>2017-08-20 16:53:47 +0200
committerGitHub <noreply@github.com>2017-08-20 16:53:47 +0200
commitfe5b66aa0870212e27a6632fb9c83a2d16bd99ab (patch)
tree4a5b53f21f2c29462d5c58afa2f2a03b30f702c4 /app/lib/activitypub/activity/like.rb
parent93d4192a67fde9aaf0c4e420cb5ecb5fe921e97c (diff)
Handle duplicate ActivityPub activities (#4639)
* Handle duplicate ActivityPub activities

Only perform side-effects when record processed for the first time

* Fast-forward repeat follow requests
Diffstat (limited to 'app/lib/activitypub/activity/like.rb')
-rw-r--r--app/lib/activitypub/activity/like.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/app/lib/activitypub/activity/like.rb b/app/lib/activitypub/activity/like.rb
index c24527597..674d5fe47 100644
--- a/app/lib/activitypub/activity/like.rb
+++ b/app/lib/activitypub/activity/like.rb
@@ -4,9 +4,9 @@ class ActivityPub::Activity::Like < ActivityPub::Activity
   def perform
     original_status = status_from_uri(object_uri)
 
-    return if original_status.nil? || !original_status.account.local? || delete_arrived_first?(@json['id'])
+    return if original_status.nil? || !original_status.account.local? || delete_arrived_first?(@json['id']) || @account.favourited?(original_status)
 
-    favourite = original_status.favourites.where(account: @account).first_or_create!(account: @account)
+    favourite = original_status.favourites.create!(account: @account)
     NotifyService.new.call(original_status.account, favourite)
   end
 end