about summary refs log tree commit diff
path: root/app/lib/settings
diff options
context:
space:
mode:
authorabcang <abcang1015@gmail.com>2020-07-15 02:05:07 +0900
committerGitHub <noreply@github.com>2020-07-14 19:05:07 +0200
commit6a96af4d20129cea06c716393338aa4f730b7b35 (patch)
tree071f96680125fb4120fc54c1c7ef646bedcf54f3 /app/lib/settings
parenta8e84a18f1d84943e8332ff8deba9d91b1cb3efd (diff)
Fix rubocop warning (#14288)
* Fix rubocop warning

* use limit variable

* use ContextCreatingMethods option
Diffstat (limited to 'app/lib/settings')
-rw-r--r--app/lib/settings/scoped_settings.rb5
1 files changed, 2 insertions, 3 deletions
diff --git a/app/lib/settings/scoped_settings.rb b/app/lib/settings/scoped_settings.rb
index 9ca39510a..3bec9bd56 100644
--- a/app/lib/settings/scoped_settings.rb
+++ b/app/lib/settings/scoped_settings.rb
@@ -11,7 +11,7 @@ module Settings
       @object = object
     end
 
-    # rubocop:disable Style/MethodMissing
+    # rubocop:disable Style/MethodMissingSuper
     def method_missing(method, *args)
       method_name = method.to_s
       # set a value for a variable
@@ -24,7 +24,7 @@ module Settings
         self[method_name]
       end
     end
-    # rubocop:enable Style/MethodMissing
+    # rubocop:enable Style/MethodMissingSuper
 
     def respond_to_missing?(*)
       true
@@ -48,7 +48,6 @@ module Settings
       record.update!(value: value)
 
       Rails.cache.write(Setting.cache_key(key, @object), value)
-      value
     end
 
     def [](key)