diff options
| author | Paul Woolcock <paul@woolcock.us> | 2019-05-21 07:28:49 -0400 |
|---|---|---|
| committer | multiple creatures <dev@multiple-creature.party> | 2019-11-19 13:20:27 -0600 |
| commit | ecbcebb917da2171acd81c8edac6f93c30fefed2 (patch) | |
| tree | 5cd91ba2a7542fd5ec484968ffbe311dfa782e5b /app/models | |
| parent | 98d4ac4eee16b660f84150228e8ffbe128180730 (diff) | |
Add `account_id` param to `GET /api/v1/notifications` (#10796)
* Add `from_account` to notifications API this adds the ability to filter notifications by the account they originated from * passing a non-existent user should cause none to be returned * Fix codeclimate warnings * fix more codeclimate warnings * make requested changes: * use account id instead of user@domain * name the param `account_id` instead of `from_account` * Don't use `return` in a lambda
Diffstat (limited to 'app/models')
| -rw-r--r-- | app/models/notification.rb | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/app/models/notification.rb b/app/models/notification.rb index 300269e24..498673ff1 100644 --- a/app/models/notification.rb +++ b/app/models/notification.rb @@ -41,9 +41,13 @@ class Notification < ApplicationRecord validates :account_id, uniqueness: { scope: [:activity_type, :activity_id] } validates :activity_type, inclusion: { in: TYPE_CLASS_MAP.values } - scope :browserable, ->(exclude_types = []) { + scope :browserable, ->(exclude_types = [], account_id = nil) { types = TYPE_CLASS_MAP.values - activity_types_from_types(exclude_types + [:follow_request]) - where(activity_type: types) + if account_id.nil? + where(activity_type: types) + else + where(activity_type: types, from_account_id: account_id) + end } cache_associated :from_account, status: STATUS_INCLUDES, mention: [status: STATUS_INCLUDES], favourite: [:account, status: STATUS_INCLUDES], follow: :account, poll: [status: STATUS_INCLUDES] |