diff options
| author | unarist <m.unarist@gmail.com> | 2017-10-18 01:32:25 +0900 |
|---|---|---|
| committer | Eugen Rochko <eugen@zeonfederated.com> | 2017-10-17 18:32:25 +0200 |
| commit | 3bc8924940ac37b1efa458e160e51f4f0e328d6b (patch) | |
| tree | f5a9050ee9861c6f0b7b15744c55eb2745199dc0 /app/services/fetch_link_card_service.rb | |
| parent | a02de9e0128752c1ec2bd53835d2c065b91601d8 (diff) | |
Don't capture scheme-less URLs in the status (#5435)
Specifically, this fixes status length calculation to be same as JS side. BTW, since this pattern used in not only preview card fetching, we should extract it (with twitter-regex?) and write tests I think.
Diffstat (limited to 'app/services/fetch_link_card_service.rb')
| -rw-r--r-- | app/services/fetch_link_card_service.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/fetch_link_card_service.rb b/app/services/fetch_link_card_service.rb index 7029c4d75..14c21b6cc 100644 --- a/app/services/fetch_link_card_service.rb +++ b/app/services/fetch_link_card_service.rb @@ -3,7 +3,7 @@ class FetchLinkCardService < BaseService URL_PATTERN = %r{ ( # $1 URL - (https?:\/\/)? # $2 Protocol (optional) + (https?:\/\/) # $2 Protocol (required) (#{Twitter::Regex[:valid_domain]}) # $3 Domain(s) (?::(#{Twitter::Regex[:valid_port_number]}))? # $4 Port number (optional) (/#{Twitter::Regex[:valid_url_path]}*)? # $5 URL Path and anchor |