diff options
| author | Eugen Rochko <eugen@zeonfederated.com> | 2016-11-15 16:56:29 +0100 |
|---|---|---|
| committer | Eugen Rochko <eugen@zeonfederated.com> | 2016-11-15 16:56:29 +0100 |
| commit | fdc17bea58f210f62ac0d9e836b68e84c6dbd15c (patch) | |
| tree | 491613c94695ba867e81d50124e7e3eb73a0eff5 /app/services/update_remote_profile_service.rb | |
| parent | a91c3ef6cef0fe5a1645c043e7d4a5ef96e82c4f (diff) | |
Fix rubocop issues, introduce usage of frozen literal to improve performance
Diffstat (limited to 'app/services/update_remote_profile_service.rb')
| -rw-r--r-- | app/services/update_remote_profile_service.rb | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/app/services/update_remote_profile_service.rb b/app/services/update_remote_profile_service.rb index 14f8cc868..2909ae12a 100644 --- a/app/services/update_remote_profile_service.rb +++ b/app/services/update_remote_profile_service.rb @@ -1,14 +1,16 @@ +# frozen_string_literal: true + class UpdateRemoteProfileService < BaseService POCO_NS = 'http://portablecontacts.net/spec/1.0' def call(author_xml, account) return if author_xml.nil? - if author_xml.at_xpath('./poco:displayName', poco: POCO_NS).nil? - account.display_name = account.username - else - account.display_name = author_xml.at_xpath('./poco:displayName', poco: POCO_NS).content - end + account.display_name = if author_xml.at_xpath('./poco:displayName', poco: POCO_NS).nil? + account.username + else + author_xml.at_xpath('./poco:displayName', poco: POCO_NS).content + end unless author_xml.at_xpath('./poco:note').nil? account.note = author_xml.at_xpath('./poco:note', poco: POCO_NS).content |