about summary refs log tree commit diff
path: root/app/services
diff options
context:
space:
mode:
authorEugen Rochko <eugen@zeonfederated.com>2017-09-02 20:44:41 +0200
committerGitHub <noreply@github.com>2017-09-02 20:44:41 +0200
commitd3b67461735f9a1c38a7eee655a8131bcf6a0cbf (patch)
tree3228ad4c8a815867c0ddd6e4f2806686636d2292 /app/services
parent2a5d1d5a1b2a3c152f2deadac3308f655b6e96be (diff)
Make "unfollow" undo pending outgoing follow request too (#4781)
* Make "unfollow" undo pending outgoing follow request too

* Add cancel button to web UI when awaiting follow request approval

* Make the hourglass button do the cancelling
Diffstat (limited to 'app/services')
-rw-r--r--app/services/process_interaction_service.rb4
-rw-r--r--app/services/unfollow_service.rb28
2 files changed, 28 insertions, 4 deletions
diff --git a/app/services/process_interaction_service.rb b/app/services/process_interaction_service.rb
index cc99cde03..d04e926e7 100644
--- a/app/services/process_interaction_service.rb
+++ b/app/services/process_interaction_service.rb
@@ -67,10 +67,13 @@ class ProcessInteractionService < BaseService
 
   def follow!(account, target_account)
     follow = account.follow!(target_account)
+    FollowRequest.find_by(account: account, target_account: target_account)&.destroy
     NotifyService.new.call(target_account, follow)
   end
 
   def follow_request!(account, target_account)
+    return if account.requested?(target_account)
+
     follow_request = FollowRequest.create!(account: account, target_account: target_account)
     NotifyService.new.call(target_account, follow_request)
   end
@@ -88,6 +91,7 @@ class ProcessInteractionService < BaseService
 
   def unfollow!(account, target_account)
     account.unfollow!(target_account)
+    FollowRequest.find_by(account: account, target_account: target_account)&.destroy
   end
 
   def reflect_block!(account, target_account)
diff --git a/app/services/unfollow_service.rb b/app/services/unfollow_service.rb
index bf151ee28..73a64929f 100644
--- a/app/services/unfollow_service.rb
+++ b/app/services/unfollow_service.rb
@@ -5,14 +5,34 @@ class UnfollowService < BaseService
   # @param [Account] source_account Where to unfollow from
   # @param [Account] target_account Which to unfollow
   def call(source_account, target_account)
-    follow = source_account.unfollow!(target_account)
+    @source_account = source_account
+    @target_account = target_account
+
+    unfollow! || undo_follow_request!
+  end
+
+  private
+
+  def unfollow!
+    follow = Follow.find_by(account: @source_account, target_account: @target_account)
+
     return unless follow
-    create_notification(follow) unless target_account.local?
-    UnmergeWorker.perform_async(target_account.id, source_account.id)
+
+    follow.destroy!
+    create_notification(follow) unless @target_account.local?
+    UnmergeWorker.perform_async(@target_account.id, @source_account.id)
     follow
   end
 
-  private
+  def undo_follow_request!
+    follow_request = FollowRequest.find_by(account: @source_account, target_account: @target_account)
+
+    return unless follow_request
+
+    follow_request.destroy!
+    create_notification(follow_request) unless @target_account.local?
+    follow_request
+  end
 
   def create_notification(follow)
     if follow.target_account.ostatus?