about summary refs log tree commit diff
path: root/app/services
diff options
context:
space:
mode:
authoraschmitz <aschmitz@lardbucket.org>2017-11-11 14:37:23 -0600
committeraschmitz <aschmitz@lardbucket.org>2017-11-11 14:37:23 -0600
commit5128c4261e8c067321e70ffda560f14036f56bb0 (patch)
tree3dc0830509a5d8535f56e257fd034a7474570f02 /app/services
parentb95c48748cd4e7a1181cdf3f17e23d6e526a9d95 (diff)
Updates per code review
Thanks, @valerauko!
Diffstat (limited to 'app/services')
-rw-r--r--app/services/follow_service.rb6
1 files changed, 2 insertions, 4 deletions
diff --git a/app/services/follow_service.rb b/app/services/follow_service.rb
index 6db591999..20579ca63 100644
--- a/app/services/follow_service.rb
+++ b/app/services/follow_service.rb
@@ -6,6 +6,7 @@ class FollowService < BaseService
   # Follow a remote user, notify remote user about the follow
   # @param [Account] source_account From which to follow
   # @param [String, Account] uri User URI to follow in the form of username@domain (or account record)
+  # @param [true, false, nil] reblogs Whether or not to show reblogs, defaults to true
   def call(source_account, uri, reblogs: nil)
     reblogs = true if reblogs.nil?
     target_account = uri.is_a?(Account) ? uri : ResolveRemoteAccountService.new.call(uri)
@@ -22,10 +23,7 @@ class FollowService < BaseService
       # This isn't managed by a method in AccountInteractions, so we modify it
       # ourselves if necessary.
       req = follow_requests.find_by(target_account: other_account)
-      if req.show_reblogs != reblogs
-        req.show_reblogs = reblogs
-        req.save!
-      end
+      req.update!(show_reblogs: reblogs)
       return
     end