diff options
| author | Eugen Rochko <eugen@zeonfederated.com> | 2018-05-30 02:50:23 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-05-30 02:50:23 +0200 |
| commit | a7d726c3836a87006cedcdc4bd186f8aff89d093 (patch) | |
| tree | d1a2e321c043d61ad66f0da3f0e732b0ae75938d /app/services | |
| parent | 461542784b555237316f3dd5e32ea224cd3ab8ef (diff) | |
Improve counter caches on Status and Account (#7644)
Do not touch statuses_count on accounts table when mass-destroying statuses to reduce load when removing accounts, same for reblogs_count and favourites_count Do not count statuses with direct visibility in statuses_count Fix #828
Diffstat (limited to 'app/services')
| -rw-r--r-- | app/services/batched_remove_status_service.rb | 5 | ||||
| -rw-r--r-- | app/services/suspend_account_service.rb | 7 |
2 files changed, 8 insertions, 4 deletions
diff --git a/app/services/batched_remove_status_service.rb b/app/services/batched_remove_status_service.rb index dab1c4794..ebb4034aa 100644 --- a/app/services/batched_remove_status_service.rb +++ b/app/services/batched_remove_status_service.rb @@ -21,7 +21,10 @@ class BatchedRemoveStatusService < BaseService @activity_xml = {} # Ensure that rendered XML reflects destroyed state - statuses.each(&:destroy) + statuses.each do |status| + status.mark_for_mass_destruction! + status.destroy + end # Batch by source account statuses.group_by(&:account_id).each_value do |account_statuses| diff --git a/app/services/suspend_account_service.rb b/app/services/suspend_account_service.rb index 56fa2d8dd..708d15e37 100644 --- a/app/services/suspend_account_service.rb +++ b/app/services/suspend_account_service.rb @@ -41,9 +41,10 @@ class SuspendAccountService < BaseService end def purge_profile! - @account.suspended = true - @account.display_name = '' - @account.note = '' + @account.suspended = true + @account.display_name = '' + @account.note = '' + @account.statuses_count = 0 @account.avatar.destroy @account.header.destroy @account.save! |