about summary refs log tree commit diff
path: root/app/services
diff options
context:
space:
mode:
authorThibG <thib@sitedethib.com>2020-01-12 14:17:03 +0100
committerEugen Rochko <eugen@zeonfederated.com>2020-01-12 14:17:03 +0100
commitd386d89179ccc2b86894a8639b658f4ede24c5f6 (patch)
tree689b34cf728a7a0754a9834f2d49173548573be5 /app/services
parent7da54001fe21d1fd10ede5ac78e5c76f25afc08e (diff)
Fix invalid votes from the API being accepted (#12601)
* Fix invalid votes from the API being accepted

Fixes #12556

- Ensure `choice` is an integer instead of silently converting to 0
- Ensure `choice` corresponds to an actual choice of the poll

* Please CodeClimate
Diffstat (limited to 'app/services')
-rw-r--r--app/services/vote_service.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/vote_service.rb b/app/services/vote_service.rb
index cb7dce6e8..19e453332 100644
--- a/app/services/vote_service.rb
+++ b/app/services/vote_service.rb
@@ -20,7 +20,7 @@ class VoteService < BaseService
 
         ApplicationRecord.transaction do
           @choices.each do |choice|
-            @votes << @poll.votes.create!(account: @account, choice: choice)
+            @votes << @poll.votes.create!(account: @account, choice: Integer(choice))
           end
         end
       else