about summary refs log tree commit diff
path: root/app/validators/html_validator.rb
diff options
context:
space:
mode:
authorThibG <thib@sitedethib.com>2019-04-10 22:33:41 +0200
committerGitHub <noreply@github.com>2019-04-10 22:33:41 +0200
commit31e4fcb006c6ef2d8e1a4c765e897afa1cba1b5c (patch)
tree15a022b1b44f72fee2d83cfe6f8355b7334f9d9b /app/validators/html_validator.rb
parentcb410f80a40d03b509cec244b0cdd4ed3957c6a0 (diff)
parent2f422b708f75bea87a49eb879ec3e0c3f35c2f9b (diff)
Merge pull request #985 from ThibG/glitch-soc/merge-upstream
Merge upstream changes
Diffstat (limited to 'app/validators/html_validator.rb')
-rw-r--r--app/validators/html_validator.rb12
1 files changed, 7 insertions, 5 deletions
diff --git a/app/validators/html_validator.rb b/app/validators/html_validator.rb
index b7caee5a9..1c9cd303c 100644
--- a/app/validators/html_validator.rb
+++ b/app/validators/html_validator.rb
@@ -1,18 +1,20 @@
 # frozen_string_literal: true
 
 class HtmlValidator < ActiveModel::EachValidator
+  ERROR_RE = /Opening and ending tag mismatch|Unexpected end tag/
+
   def validate_each(record, attribute, value)
     return if value.blank?
+
     errors = html_errors(value)
-    unless errors.empty?
-      record.errors.add(attribute, I18n.t('html_validator.invalid_markup', error: errors.first.to_s))
-    end
+
+    record.errors.add(attribute, I18n.t('html_validator.invalid_markup', error: errors.first.to_s)) unless errors.empty?
   end
 
   private
 
   def html_errors(str)
-    fragment = Nokogiri::HTML.fragment(str)
-    fragment.errors
+    fragment = Nokogiri::HTML.fragment(options[:wrap_with] ? "<#{options[:wrap_with]}>#{str}</#{options[:wrap_with]}>" : str)
+    fragment.errors.select { |error| ERROR_RE =~ error.message }
   end
 end