about summary refs log tree commit diff
path: root/app
diff options
context:
space:
mode:
authorDavid Yip <yipdw@member.fsf.org>2017-12-06 16:19:43 -0600
committerDavid Yip <yipdw@member.fsf.org>2017-12-06 16:19:43 -0600
commit017fc81caf8f265e5c5543186877437485625795 (patch)
treecd2b7f699b1f067f284826e588a257771d285fb0 /app
parent5bed0f10ed4628049ca14fb188804654574be1bf (diff)
Prepend check_enabled_deletion to Settings::DeletesController (#229)
The specs for Settings::DeletesController include an example that
sets Settings.open_deletion to false and expects the "if deletion is not
available, redirect to root" logic to run.  However, this spec does not
set up a user, which means that the spec (intentionally or otherwise)
expects this redirection to work with unauthenticated access.

We should preserve that behavior.  To do so, we prepend the deletion
check to the action chain set up by Settings::BaseController, so that
said check occurs before the authenticate_user! check.
Diffstat (limited to 'app')
-rw-r--r--app/controllers/settings/deletes_controller.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/app/controllers/settings/deletes_controller.rb b/app/controllers/settings/deletes_controller.rb
index e4cb35a8e..4c1121471 100644
--- a/app/controllers/settings/deletes_controller.rb
+++ b/app/controllers/settings/deletes_controller.rb
@@ -2,7 +2,7 @@
 
 class Settings::DeletesController < Settings::BaseController
 
-  before_action :check_enabled_deletion
+  prepend_before_action :check_enabled_deletion
 
   def show
     @confirmation = Form::DeleteConfirmation.new