about summary refs log tree commit diff
path: root/app
diff options
context:
space:
mode:
authorDavid Yip <yipdw@member.fsf.org>2018-01-09 14:16:45 -0600
committerDavid Yip <yipdw@member.fsf.org>2018-01-09 14:16:45 -0600
commit991371af5f22ba85199f3f66bab5f70b404de95f (patch)
tree3e5652e1d90596c57b70d2afac72b17f183b8734 /app
parente780d5951b7eb743a718d9b34a46cd8fa5561636 (diff)
parent35b84985a8b9e57cfd3ffac8a0e3937d3c7a1167 (diff)
Merge remote-tracking branch 'origin/master' into merge-upstream
 Conflicts:
	db/schema.rb
Diffstat (limited to 'app')
-rw-r--r--app/lib/activitypub/activity/announce.rb6
-rw-r--r--app/lib/ostatus/activity/creation.rb3
-rw-r--r--app/views/stream_entries/show.html.haml2
3 files changed, 9 insertions, 2 deletions
diff --git a/app/lib/activitypub/activity/announce.rb b/app/lib/activitypub/activity/announce.rb
index b84098933..abf2b9b80 100644
--- a/app/lib/activitypub/activity/announce.rb
+++ b/app/lib/activitypub/activity/announce.rb
@@ -5,7 +5,7 @@ class ActivityPub::Activity::Announce < ActivityPub::Activity
     original_status   = status_from_uri(object_uri)
     original_status ||= fetch_remote_original_status
 
-    return if original_status.nil? || delete_arrived_first?(@json['id'])
+    return if original_status.nil? || delete_arrived_first?(@json['id']) || !announceable?(original_status)
 
     status = Status.find_by(account: @account, reblog: original_status)
 
@@ -33,4 +33,8 @@ class ActivityPub::Activity::Announce < ActivityPub::Activity
       ::FetchRemoteStatusService.new.call(@object['url'])
     end
   end
+
+  def announceable?(status)
+    status.public_visibility? || status.unlisted_visibility?
+  end
 end
diff --git a/app/lib/ostatus/activity/creation.rb b/app/lib/ostatus/activity/creation.rb
index f210e134a..b38407cd3 100644
--- a/app/lib/ostatus/activity/creation.rb
+++ b/app/lib/ostatus/activity/creation.rb
@@ -26,6 +26,9 @@ class OStatus::Activity::Creation < OStatus::Activity::Base
     cached_reblog = reblog
     status = nil
 
+    # Skip if the reblogged status is not public
+    return if cached_reblog && !(cached_reblog.public_visibility? || cached_reblog.unlisted_visibility?)
+
     media_attachments = save_media
 
     ApplicationRecord.transaction do
diff --git a/app/views/stream_entries/show.html.haml b/app/views/stream_entries/show.html.haml
index b52334a28..cf6671e67 100644
--- a/app/views/stream_entries/show.html.haml
+++ b/app/views/stream_entries/show.html.haml
@@ -1,5 +1,5 @@
 - content_for :page_title do
-  = t('statuses.title', name: display_name(@account), quote: truncate(@stream_entry.activity.text, length: 50, omission: '…'))
+  = t('statuses.title', name: display_name(@account), quote: truncate(@stream_entry.activity.spoiler_text.presence || @stream_entry.activity.text, length: 50, omission: '…'))
 
 - content_for :header_tags do
   - if @account.user&.setting_noindex