about summary refs log tree commit diff
path: root/boxfile.yml
diff options
context:
space:
mode:
authorEugen Rochko <eugen@zeonfederated.com>2018-02-21 03:40:12 +0100
committerGitHub <noreply@github.com>2018-02-21 03:40:12 +0100
commita7171af0a34f612d05667f1a5c35a4ca834da082 (patch)
treef4a941ca49d4a0b879906a252e26c89a88fc21b0 /boxfile.yml
parenta4fd4ad1d50221f4a6a032d3ffea6f620e8b9b5b (diff)
Fix avatar and header issues by using custom geometry detector (#6515)
* Fix avatar and header issues by using custom geometry detector

Revert a part of #6508. The file passed to dynamic styles method
was not actually a file, but an instance of Paperclip::Attachment,
which broke all styles by always returning {} from the method.

One problem with GIF avatars was that Paperclip::GeometryDetector
reported wrong dimensions for them, e.g. 120x120 GIF avatar would
for some reason be detected as 120x53. By writing our own geometry
parser, we can use FastImage, which also happens to be faster than
ImageMagick, to detect image dimensions, which are also correct.

Unfortunately, this PR does not implement skipping a `convert`
entirely if the dimensions are already correct, as I found no easy
way to write that behaviour into Paperclip without rewriting the
Paperclip::Thumbnail class.

* Only invoke convert if dimension or format needs to be changed
Diffstat (limited to 'boxfile.yml')
0 files changed, 0 insertions, 0 deletions