about summary refs log tree commit diff
path: root/config/webpack
diff options
context:
space:
mode:
authorDaniel Hunsaker <danhunsaker@gmail.com>2017-05-29 09:59:18 -0600
committerEugen Rochko <eugen@zeonfederated.com>2017-05-29 17:59:18 +0200
commit9ead3d1cdbac2cc40d8926be116cbe15cbf7f24d (patch)
tree400cbb1e9fcb6f028d785d7b71de2008ed758702 /config/webpack
parent402c19a92475014e04df91eca759225f8a89d2ac (diff)
[nanobox] Adjustments for Nanobox development (#3295)
Because Nanobox doesn't run data components in the same container as the code, there are a few tweaks that need to be made in the configuration to get WebPack to work properly in development mode.

The same differences lead to needing to use `DATABASE_URL` by default in the `.env` file for Rails to work correctly.

Limitations of our `.env` loader for Node.js mean the `.env` file needs to be compiled everywhere in order to work, so we compile it in development, now, too. Also, all the `.env.production` tweaks have been consolidated into a single command.

Finally, since Nanobox actually creates the database when it sets up the database server, using the existence of the database alone to determine whether to migrate or setup is insufficient. So we add a condition to `rake db:migrate:setup` to check whether any migrations have run - if the database doesn't exist yet, `db:setup` will be called; if it does, but no migrations have been run, `db:migrate` and `db:seed` are called instead (the same basic idea as what `db:setup` does, but it skips `db:create`, which will only cause problems with an existing DB); otherwise, only `db:migrate` is called.

None of these changes should affect development, and all are designed not to interfere with existing behaviors in other environments.
Diffstat (limited to 'config/webpack')
-rw-r--r--config/webpack/configuration.js2
-rw-r--r--config/webpack/development.server.js3
2 files changed, 3 insertions, 2 deletions
diff --git a/config/webpack/configuration.js b/config/webpack/configuration.js
index 922e8c517..2a54080cf 100644
--- a/config/webpack/configuration.js
+++ b/config/webpack/configuration.js
@@ -12,7 +12,7 @@ const devServer = safeLoad(readFileSync(join(configPath, 'development.server.yml
 
 // Compute public path based on environment and CDN_HOST in production
 const ifHasCDN = env.CDN_HOST !== undefined && env.NODE_ENV === 'production';
-const devServerUrl = `http://${devServer.host}:${devServer.port}/${paths.entry}/`;
+const devServerUrl = `http://${env.LOCAL_DOMAIN || devServer.host}:${devServer.port}/${paths.entry}/`;
 const publicUrl = ifHasCDN ? `${env.CDN_HOST}/${paths.entry}/` : `/${paths.entry}/`;
 const publicPath = env.NODE_ENV !== 'production' ? devServerUrl : publicUrl;
 
diff --git a/config/webpack/development.server.js b/config/webpack/development.server.js
index 296df1504..4e11df4cb 100644
--- a/config/webpack/development.server.js
+++ b/config/webpack/development.server.js
@@ -1,13 +1,14 @@
 // Note: You must restart bin/webpack-dev-server for changes to take effect
 
 const { resolve } = require('path');
+const { env } = require('process');
 const merge = require('webpack-merge');
 const devConfig = require('./development.js');
 const { devServer, publicPath, paths } = require('./configuration.js');
 
 module.exports = merge(devConfig, {
   devServer: {
-    host: devServer.host,
+    host: env.LOCAL_DOMAIN ? '0.0.0.0' : devServer.host,
     port: devServer.port,
     headers: { "Access-Control-Allow-Origin": "*" },
     compress: true,