about summary refs log tree commit diff
path: root/db
diff options
context:
space:
mode:
authorunarist <m.unarist@gmail.com>2017-06-06 23:07:06 +0900
committerEugen Rochko <eugen@zeonfederated.com>2017-06-06 16:07:06 +0200
commit004672aa6c482b212e36b9e794d107be456a11da (patch)
tree7bde1904fe421f63adb8210179ec8eb458fe16a3 /db
parentad4a28f4f689cc9a37a5c2d5dd8c012e964903b7 (diff)
Fix tag search order and not to use tsvector (#3611)
* Sort results by the name
* Switch search method to simple `LIKE` matching instead of tsvector/tsquery

Previously we used scores from ts_rank_cd() to sort results, but it didn't work
because the function returns same score for all results. It's not for calculate
similarity of single words. Sometimes this bug even push out exact matching tag
from results.

Additionally, PostgreSQL supports prefix searching with standard btree index.
Using it offers simpler code, but also less index size and some speed.
Diffstat (limited to 'db')
-rw-r--r--db/migrate/20170606113804_change_tag_search_index_to_btree.rb12
-rw-r--r--db/schema.rb4
2 files changed, 14 insertions, 2 deletions
diff --git a/db/migrate/20170606113804_change_tag_search_index_to_btree.rb b/db/migrate/20170606113804_change_tag_search_index_to_btree.rb
new file mode 100644
index 000000000..5248e1720
--- /dev/null
+++ b/db/migrate/20170606113804_change_tag_search_index_to_btree.rb
@@ -0,0 +1,12 @@
+class ChangeTagSearchIndexToBtree < ActiveRecord::Migration[5.1]
+
+  def up
+    remove_index :tags, name: :hashtag_search_index
+    execute 'CREATE INDEX hashtag_search_index ON tags (name text_pattern_ops);'
+  end
+
+  def down
+    remove_index :tags, name: :hashtag_search_index
+    execute 'CREATE INDEX hashtag_search_index ON tags USING gin(to_tsvector(\'simple\', tags.name));'
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
index ca904569e..712f62ea6 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20170604144747) do
+ActiveRecord::Schema.define(version: 20170606113804) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -320,7 +320,7 @@ ActiveRecord::Schema.define(version: 20170604144747) do
     t.string "name", default: "", null: false
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
-    t.index "to_tsvector('simple'::regconfig, (name)::text)", name: "hashtag_search_index", using: :gin
+    t.index "name text_pattern_ops", name: "hashtag_search_index"
     t.index ["name"], name: "index_tags_on_name", unique: true
   end