diff options
author | ThibG <thib@sitedethib.com> | 2020-08-12 12:40:25 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-08-12 12:40:25 +0200 |
commit | 8d217d7231be46af552c63aff9e53d0ed5dca0f6 (patch) | |
tree | cc45f0433545e57aafee21f5aa463ff5919a6bae /spec | |
parent | 7dc4c742650ac69ec9a4459b656e172283511e4c (diff) |
Improve email address validation (#14565)
* Increase DNS timeout from 1 second to 5 seconds for MX check 1 seconds is rather short when using a recursive DNS resolver which hasn't got a cached result already available. Use 5 seconds instead, which is the timeout value we use for outgoing HTTP queries. * Add more precise error messages for invalid e-mail addresses
Diffstat (limited to 'spec')
-rw-r--r-- | spec/validators/blacklisted_email_validator_spec.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/spec/validators/blacklisted_email_validator_spec.rb b/spec/validators/blacklisted_email_validator_spec.rb index ccc5dc0f4..f0708dc46 100644 --- a/spec/validators/blacklisted_email_validator_spec.rb +++ b/spec/validators/blacklisted_email_validator_spec.rb @@ -17,7 +17,7 @@ RSpec.describe BlacklistedEmailValidator, type: :validator do let(:blocked_email) { true } it 'calls errors.add' do - expect(errors).to have_received(:add).with(:email, I18n.t('users.invalid_email')) + expect(errors).to have_received(:add).with(:email, I18n.t('users.blocked_email_provider')) end end @@ -25,7 +25,7 @@ RSpec.describe BlacklistedEmailValidator, type: :validator do let(:blocked_email) { false } it 'not calls errors.add' do - expect(errors).not_to have_received(:add).with(:email, I18n.t('users.invalid_email')) + expect(errors).not_to have_received(:add).with(:email, I18n.t('users.blocked_email_provider')) end end end |