about summary refs log tree commit diff
path: root/spec
diff options
context:
space:
mode:
authorThibaut Girka <thib@sitedethib.com>2018-07-07 21:40:49 +0200
committerThibaut Girka <thib@sitedethib.com>2018-07-09 19:19:23 +0200
commit402da8065c2b378cca6361f2c7252bd766f25dde (patch)
treeeda07c40c934ab9a55d7847afe4af3e54bce86b8 /spec
parentee41947e9defce24ecd9f46329bb953d46b335bd (diff)
Migrate glitch-soc keyword mutes to Mastodon's
Completely remove glitch-soc's Keyword Mutes, migrate
existing database records to CustomFilters.

Handling of client-side filters is still not implemented
in the glitch-soc front-end.
Diffstat (limited to 'spec')
-rw-r--r--spec/controllers/settings/keyword_mutes_controller_spec.rb5
-rw-r--r--spec/fabricators/glitch_keyword_mute_fabricator.rb2
-rw-r--r--spec/lib/feed_manager_spec.rb76
-rw-r--r--spec/models/glitch/keyword_mute_helper_spec.rb52
-rw-r--r--spec/models/glitch/keyword_mute_spec.rb171
5 files changed, 0 insertions, 306 deletions
diff --git a/spec/controllers/settings/keyword_mutes_controller_spec.rb b/spec/controllers/settings/keyword_mutes_controller_spec.rb
deleted file mode 100644
index a8c37a072..000000000
--- a/spec/controllers/settings/keyword_mutes_controller_spec.rb
+++ /dev/null
@@ -1,5 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe Settings::KeywordMutesController, type: :controller do
-
-end
diff --git a/spec/fabricators/glitch_keyword_mute_fabricator.rb b/spec/fabricators/glitch_keyword_mute_fabricator.rb
deleted file mode 100644
index 20d393320..000000000
--- a/spec/fabricators/glitch_keyword_mute_fabricator.rb
+++ /dev/null
@@ -1,2 +0,0 @@
-Fabricator('Glitch::KeywordMute') do
-end
diff --git a/spec/lib/feed_manager_spec.rb b/spec/lib/feed_manager_spec.rb
index 8305530c5..a36ebad49 100644
--- a/spec/lib/feed_manager_spec.rb
+++ b/spec/lib/feed_manager_spec.rb
@@ -134,68 +134,6 @@ RSpec.describe FeedManager do
         expect(FeedManager.instance.filter?(:home, reblog, alice.id)).to be true
       end
 
-      it 'returns true for a status containing a muted keyword' do
-        Fabricate('Glitch::KeywordMute', account: alice, keyword: 'take')
-        status = Fabricate(:status, text: 'This is a hot take', account: bob)
-
-        expect(FeedManager.instance.filter?(:home, status, alice.id)).to be true
-      end
-
-      it 'returns true for a reply containing a muted keyword' do
-        Fabricate('Glitch::KeywordMute', account: alice, keyword: 'take')
-        s1 = Fabricate(:status, text: 'Something', account: alice)
-        s2 = Fabricate(:status, text: 'This is a hot take', thread: s1, account: bob)
-
-        expect(FeedManager.instance.filter?(:home, s2, alice.id)).to be true
-      end
-
-      it 'returns true for a status whose spoiler text contains a muted keyword' do
-        Fabricate('Glitch::KeywordMute', account: alice, keyword: 'take')
-        status = Fabricate(:status, spoiler_text: 'This is a hot take', account: bob)
-
-        expect(FeedManager.instance.filter?(:home, status, alice.id)).to be true
-      end
-
-      it 'returns true for a reblog containing a muted keyword' do
-        Fabricate('Glitch::KeywordMute', account: alice, keyword: 'take')
-        status = Fabricate(:status, text: 'This is a hot take', account: bob)
-        reblog = Fabricate(:status, reblog: status, account: jeff)
-
-        expect(FeedManager.instance.filter?(:home, reblog, alice.id)).to be true
-      end
-
-      it 'returns true for a reblog whose spoiler text contains a muted keyword' do
-        Fabricate('Glitch::KeywordMute', account: alice, keyword: 'take')
-        status = Fabricate(:status, spoiler_text: 'This is a hot take', account: bob)
-        reblog = Fabricate(:status, reblog: status, account: jeff)
-
-        expect(FeedManager.instance.filter?(:home, reblog, alice.id)).to be true
-      end
-
-      it 'returns true for a status with a tag that matches a muted keyword' do
-        Fabricate('Glitch::KeywordMute', account: alice, keyword: 'jorts')
-        status = Fabricate(:status, account: bob)
-        status.tags << Fabricate(:tag, name: 'jorts')
-
-        expect(FeedManager.instance.filter?(:home, status, alice.id)).to be true
-      end
-
-      it 'returns true for a status with a tag that matches an octothorpe-prefixed muted keyword' do
-        Fabricate('Glitch::KeywordMute', account: alice, keyword: '#jorts')
-        status = Fabricate(:status, account: bob)
-        status.tags << Fabricate(:tag, name: 'jorts')
-
-        expect(FeedManager.instance.filter?(:home, status, alice.id)).to be true
-      end
-
-      it 'returns false if the status is muted by a keyword mute that does not apply to mentions' do
-        Fabricate('Glitch::KeywordMute', account: alice, keyword: 'take', apply_to_mentions: false)
-        status = Fabricate(:status, spoiler_text: 'This is a hot take', account: bob)
-        status.mentions.create!(account_id: alice.id)
-
-        expect(FeedManager.instance.filter?(:home, status, alice.id)).to be false
-      end
-
       context 'for irreversibly muted phrases' do
         it 'considers word boundaries when matching' do
           alice.custom_filters.create!(phrase: 'bob', context: %w(home), irreversible: true)
@@ -247,20 +185,6 @@ RSpec.describe FeedManager do
         bob.follow!(alice)
         expect(FeedManager.instance.filter?(:mentions, status, bob.id)).to be false
       end
-
-      it 'returns true for status that contains a muted keyword' do
-        Fabricate('Glitch::KeywordMute', account: bob, keyword: 'take')
-        status = Fabricate(:status, text: 'This is a hot take', account: alice)
-        bob.follow!(alice)
-        expect(FeedManager.instance.filter?(:mentions, status, bob.id)).to be true
-      end
-
-      it 'returns false for a mention that contains a word muted by a keyword that does not apply to mentions' do
-        Fabricate('Glitch::KeywordMute', account: bob, keyword: 'take', apply_to_mentions: false)
-        status = Fabricate(:status, text: 'This is a hot take', account: alice)
-        bob.follow!(alice)
-        expect(FeedManager.instance.filter?(:mentions, status, bob.id)).to be false
-      end
     end
   end
 
diff --git a/spec/models/glitch/keyword_mute_helper_spec.rb b/spec/models/glitch/keyword_mute_helper_spec.rb
deleted file mode 100644
index f9408d62d..000000000
--- a/spec/models/glitch/keyword_mute_helper_spec.rb
+++ /dev/null
@@ -1,52 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe Glitch::KeywordMuteHelper do
-  describe '#matches?' do
-    Unscoped = Glitch::KeywordMute::Scopes::Unscoped
-
-    let(:alice) { Fabricate(:account, username: 'alice').tap(&:save!) }
-    let(:helper) { Glitch::KeywordMuteHelper.new(alice) }
-
-    it 'ignores names of HTML tags in status text' do
-      status = Fabricate(:status, text: '<addr>uh example</addr>')
-      Glitch::KeywordMute.create!(account: alice, keyword: 'addr')
-
-      expect(helper.matches?(status, Unscoped)).to be false
-    end
-
-    it 'ignores properties of HTML tags in status text' do
-      status = Fabricate(:status, text: '<a href="https://www.example.org">uh example</a>')
-      Glitch::KeywordMute.create!(account: alice, keyword: 'href')
-
-      expect(helper.matches?(status, Unscoped)).to be false
-    end
-
-    it 'matches text inside HTML tags' do
-      status = Fabricate(:status, text: '<p>HEY THIS IS SOMETHING ANNOYING</p>')
-      Glitch::KeywordMute.create!(account: alice, keyword: 'annoying')
-
-      expect(helper.matches?(status, Unscoped)).to be true
-    end
-
-    it 'matches < in HTML-stripped text' do
-      status = Fabricate(:status, text: '<p>I <3 oats</p>')
-      Glitch::KeywordMute.create!(account: alice, keyword: '<3')
-
-      expect(helper.matches?(status, Unscoped)).to be true
-    end
-
-    it 'matches &lt; in HTML text' do
-      status = Fabricate(:status, text: '<p>I &lt;3 oats</p>')
-      Glitch::KeywordMute.create!(account: alice, keyword: '<3')
-
-      expect(helper.matches?(status, Unscoped)).to be true
-    end
-
-    it 'matches link hrefs in HTML text' do
-      status = Fabricate(:status, text: '<p><a href="https://example.com/it-was-milk">yep</a></p>')
-      Glitch::KeywordMute.create!(account: alice, keyword: 'milk')
-
-      expect(helper.matches?(status, Unscoped)).to be true
-    end
-  end
-end
diff --git a/spec/models/glitch/keyword_mute_spec.rb b/spec/models/glitch/keyword_mute_spec.rb
deleted file mode 100644
index 12c354738..000000000
--- a/spec/models/glitch/keyword_mute_spec.rb
+++ /dev/null
@@ -1,171 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe Glitch::KeywordMute, type: :model do
-  let(:alice) { Fabricate(:account, username: 'alice').tap(&:save!) }
-  let(:bob) { Fabricate(:account, username: 'bob').tap(&:save!) }
-
-  Unscoped = Glitch::KeywordMute::Scopes::Unscoped
-
-  describe '.text_matcher_for' do
-    let(:matcher) { Glitch::KeywordMute.text_matcher_for(alice.id) }
-
-    describe 'with no mutes' do
-      before do
-        Glitch::KeywordMute.delete_all
-      end
-
-      it 'does not match' do
-        expect(matcher.matches?('This is a hot take', Unscoped)).to be_falsy
-      end
-    end
-
-    describe 'with mutes' do
-      it 'does not match keywords set by a different account' do
-        Glitch::KeywordMute.create!(account: bob, keyword: 'take')
-
-        expect(matcher.matches?('This is a hot take', Unscoped)).to be_falsy
-      end
-
-      it 'does not match if no keywords match the status text' do
-        Glitch::KeywordMute.create!(account: alice, keyword: 'cold')
-
-        expect(matcher.matches?('This is a hot take', Unscoped)).to be_falsy
-      end
-
-      it 'considers word boundaries when matching' do
-        Glitch::KeywordMute.create!(account: alice, keyword: 'bob', whole_word: true)
-
-        expect(matcher.matches?('bobcats', Unscoped)).to be_falsy
-      end
-
-      it 'matches substrings if whole_word is false' do
-        Glitch::KeywordMute.create!(account: alice, keyword: 'take', whole_word: false)
-
-        expect(matcher.matches?('This is a shiitake mushroom', Unscoped)).to be_truthy
-      end
-
-      it 'matches keywords at the beginning of the text' do
-        Glitch::KeywordMute.create!(account: alice, keyword: 'take')
-
-        expect(matcher.matches?('Take this', Unscoped)).to be_truthy
-      end
-
-      it 'matches keywords at the end of the text' do
-        Glitch::KeywordMute.create!(account: alice, keyword: 'take')
-
-        expect(matcher.matches?('This is a hot take', Unscoped)).to be_truthy
-      end
-
-      it 'matches if at least one keyword case-insensitively matches the text' do
-        Glitch::KeywordMute.create!(account: alice, keyword: 'hot')
-
-        expect(matcher.matches?('This is a HOT take', Unscoped)).to be_truthy
-      end
-
-      it 'matches if at least one non-whole-word keyword case-insensitively matches the text' do
-        Glitch::KeywordMute.create!(account: alice, keyword: 'hot', whole_word: false)
-
-        expect(matcher.matches?('This is a HOTTY take', Unscoped)).to be_truthy
-      end
-
-      it 'maintains case-insensitivity when combining keywords into a single matcher' do
-        Glitch::KeywordMute.create!(account: alice, keyword: 'hot')
-        Glitch::KeywordMute.create!(account: alice, keyword: 'cold')
-
-        expect(matcher.matches?('This is a HOT take', Unscoped)).to be_truthy
-      end
-
-      it 'matches keywords surrounded by non-alphanumeric ornamentation' do
-        Glitch::KeywordMute.create!(account: alice, keyword: 'hot')
-
-        expect(matcher.matches?('(hot take)', Unscoped)).to be_truthy
-      end
-
-      it 'escapes metacharacters in whole-word keywords' do
-        Glitch::KeywordMute.create!(account: alice, keyword: '(hot take)')
-
-        expect(matcher.matches?('(hot take)', Unscoped)).to be_truthy
-      end
-
-      it 'escapes metacharacters in non-whole-word keywords' do
-        Glitch::KeywordMute.create!(account: alice, keyword: '(-', whole_word: false)
-
-        expect(matcher.matches?('bad (-)', Unscoped)).to be_truthy
-      end
-
-      it 'uses case-folding rules appropriate for more than just English' do
-        Glitch::KeywordMute.create!(account: alice, keyword: 'großeltern')
-
-        expect(matcher.matches?('besuch der grosseltern', Unscoped)).to be_truthy
-      end
-
-      it 'matches keywords that are composed of multiple words' do
-        Glitch::KeywordMute.create!(account: alice, keyword: 'a shiitake')
-
-        expect(matcher.matches?('This is a shiitake', Unscoped)).to be_truthy
-        expect(matcher.matches?('This is shiitake', Unscoped)).to_not be_truthy
-      end
-    end
-  end
-
-  describe '.tag_matcher_for' do
-    let(:matcher) { Glitch::KeywordMute.tag_matcher_for(alice.id) }
-    let(:status) { Fabricate(:status) }
-
-    describe 'with no mutes' do
-      before do
-        Glitch::KeywordMute.delete_all
-      end
-
-      it 'does not match' do
-        status.tags << Fabricate(:tag, name: 'xyzzy')
-
-        expect(matcher.matches?(status.tags, Unscoped)).to be false
-      end
-    end
-
-    describe 'with mutes' do
-      it 'does not match keywords set by a different account' do
-        status.tags << Fabricate(:tag, name: 'xyzzy')
-        Glitch::KeywordMute.create!(account: bob, keyword: 'take')
-
-        expect(matcher.matches?(status.tags, Unscoped)).to be false
-      end
-
-      it 'matches #xyzzy when given the mute "#xyzzy"' do
-        status.tags << Fabricate(:tag, name: 'xyzzy')
-        Glitch::KeywordMute.create!(account: alice, keyword: '#xyzzy')
-
-        expect(matcher.matches?(status.tags, Unscoped)).to be true
-      end
-
-      it 'matches #thingiverse when given the non-whole-word mute "#thing"' do
-        status.tags << Fabricate(:tag, name: 'thingiverse')
-        Glitch::KeywordMute.create!(account: alice, keyword: '#thing', whole_word: false)
-
-        expect(matcher.matches?(status.tags, Unscoped)).to be true
-      end
-
-      it 'matches #hashtag when given the mute "##hashtag""' do
-        status.tags << Fabricate(:tag, name: 'hashtag')
-        Glitch::KeywordMute.create!(account: alice, keyword: '##hashtag')
-
-        expect(matcher.matches?(status.tags, Unscoped)).to be true
-      end
-
-      it 'matches #oatmeal when given the non-whole-word mute "oat"' do
-        status.tags << Fabricate(:tag, name: 'oatmeal')
-        Glitch::KeywordMute.create!(account: alice, keyword: 'oat', whole_word: false)
-
-        expect(matcher.matches?(status.tags, Unscoped)).to be true
-      end
-
-      it 'does not match #oatmeal when given the mute "#oat"' do
-        status.tags << Fabricate(:tag, name: 'oatmeal')
-        Glitch::KeywordMute.create!(account: alice, keyword: 'oat')
-
-        expect(matcher.matches?(status.tags, Unscoped)).to be false
-      end
-    end
-  end
-end