about summary refs log tree commit diff
path: root/app
AgeCommit message (Collapse)Author
2020-08-24Add WebAuthn as an alternative 2FA method (#14466)santiagorodriguez96
* feat: add possibility of adding WebAuthn security keys to use as 2FA This adds a basic UI for enabling WebAuthn 2FA. We did a little refactor to the Settings page for editing the 2FA methods – now it will list the methods that are available to the user (TOTP and WebAuthn) and from there they'll be able to add or remove any of them. Also, it's worth mentioning that for enabling WebAuthn it's required to have TOTP enabled, so the first time that you go to the 2FA Settings page, you'll be asked to set it up. This work was inspired by the one donde by Github in their platform, and despite it could be approached in different ways, we decided to go with this one given that we feel that this gives a great UX. Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: add request for WebAuthn as second factor at login if enabled This commits adds the feature for using WebAuthn as a second factor for login when enabled. If users have WebAuthn enabled, now a page requesting for the use of a WebAuthn credential for log in will appear, although a link redirecting to the old page for logging in using a two-factor code will also be present. Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: add possibility of deleting WebAuthn Credentials Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: disable WebAuthn when an Admin disables 2FA for a user Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: remove ability to disable TOTP leaving only WebAuthn as 2FA Following examples form other platforms like Github, we decided to make Webauthn 2FA secondary to 2FA with TOTP, so that we removed the possibility of removing TOTP authentication only, leaving users with just WEbAuthn as 2FA. Instead, users will have to click on 'Disable 2FA' in order to remove second factor auth. The reason for WebAuthn being secondary to TOPT is that in that way, users will still be able to log in using their code from their phone's application if they don't have their security keys with them – or maybe even lost them. * We had to change a little the flow for setting up TOTP, given that now it's possible to setting up again if you already had TOTP, in order to let users modify their authenticator app – given that now it's not possible for them to disable TOTP and set it up again with another authenticator app. So, basically, now instead of storing the new `otp_secret` in the user, we store it in the session until the process of set up is finished. This was because, as it was before, when users clicked on 'Edit' in the new two-factor methods lists page, but then went back without finishing the flow, their `otp_secret` had been changed therefore invalidating their previous authenticator app, making them unable to log in again using TOTP. Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * refactor: fix eslint errors The PR build was failing given that linting returning some errors. This commit attempts to fix them. * refactor: normalize i18n translations The build was failing given that i18n translations files were not normalized. This commits fixes that. * refactor: avoid having the webauthn gem locked to a specific version * refactor: use symbols for routes without '/' * refactor: avoid sending webauthn disabled email when 2FA is disabled When an admins disable 2FA for users, we were sending two mails to them, one notifying that 2FA was disabled and the other to notify that WebAuthn was disabled. As the second one is redundant since the first email includes it, we can remove it and send just one email to users. * refactor: avoid creating new env variable for webauthn_origin config * refactor: improve flash error messages for webauthn pages Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
2020-08-24Fix: also use custom private boost icon for detailed status (#14471)Tdxdxoz
* use custom private boost icon for detail status * only use className
2020-08-24Add support for inlined objects in activity audience (#14514)ThibG
* Add support for inlined objects in activity audience * Add tests
2020-08-24Better manage subscriptionCounters (#14608)Daigo 3 Dango
Before this change: - unsubscribe() was not called for a disconnection - It seems that WebSocketClient calls connected() and reconnected(). subscriptionCounters were incremented twice for a single reconnection, first from connected() and second from reconnected() This might be a an additional change to https://github.com/tootsuite/mastodon/pull/14579 to recover subscriptions after a reconnect.
2020-08-23reword "boost to original audience" as per #14596 (#14598)proxy
2020-08-23Fix click range discrepancies in gifv (#14615)Takeshi Umeda
2020-08-21Fix scrolling issues when closing some dropdown menus (#14606)ThibG
2020-08-19Merge branch 'master' into glitch-soc/merge-upstreamThibaut Girka
2020-08-19Fix not being able to unbookmark toots when blocked by their author (#14604)ThibG
* Fix not being able to unbookmark toots when blocked by their author * Add tests
2020-08-19Fix client-side form validation not accepting handles with uppercase letters ↵ThibG
(#14599)
2020-08-17Change styling to always have scrollbar on search resultsThibaut Girka
2020-08-17Fix WebUI crash in edge case when media display size causes scrollThibaut Girka
Fixes #1406
2020-08-13Fix styling of display names and account handles, make it closer to upstreamThibaut Girka
2020-08-13[Glitch] Add client-side validation in password change formsThibG
Port 7dc4c742650ac69ec9a4459b656e172283511e4c to glitch-soc Signed-off-by: Thibaut Girka <thib@sitedethib.com>
2020-08-13[Glitch] Add HTML form validation for the registration formThibG
Port d70c3ab4c39e642d41138ab693af77dd6c258e8c to glitch-soc Signed-off-by: Thibaut Girka <thib@sitedethib.com>
2020-08-13Merge branch 'master' into glitch-soc/merge-upstreamThibaut Girka
2020-08-13Fix hardcoded non-breaking space in public view (#14568)ThibG
2020-08-12Improve email address validation (#14565)ThibG
* Increase DNS timeout from 1 second to 5 seconds for MX check 1 seconds is rather short when using a recursive DNS resolver which hasn't got a cached result already available. Use 5 seconds instead, which is the timeout value we use for outgoing HTTP queries. * Add more precise error messages for invalid e-mail addresses
2020-08-12Add client-side validation in password change forms (#14564)ThibG
* Fix client-side username validation at registration It used the Account::USERNAME_RE regexp which is for *remote* users, local user validation is stricter. Also take into account max username length. * Add client-side form validation for password change * Add client-side form validation to dedicated registration form Previous changes only applied to the /about page, not the dedicated form on /auth
2020-08-12Fix local-only flag not necessarily being preserved on delete & redraftThibaut Girka
2020-08-12Fix embedded playerThibaut Girka
(broken because I forgot to adapt it to glitch-soc's theming system)
2020-08-11Add HTML form validation for the registration form (#14560)ThibG
* Add HTML-level validation of username in sign-up form * Make required fields with incorrect values more visible * Enable HTML form validation for the registration form * Mark agreement checkbox as required client-side * Add minimum length to password * Add client-side password confirmation validation
2020-08-11Fix new audio player when under content warningsThibaut Girka
2020-08-11[Glitch] Add support for managing multiple stream subscriptions in a single ↵Eugen Rochko
connection Ported ef057584fd2714d94666f9ffef4aa89147eda72c to glitch-soc Signed-off-by: Thibaut Girka <thib@sitedethib.com>
2020-08-11Merge branch 'master' into glitch-soc/masterThibaut Girka
Conflicts: - `streaming/index.js`: Upstream entirely refactored it. Ported our changes to upstream's refactor. Hopefuly.
2020-08-11Add support for managing multiple stream subscriptions in a single ↵Eugen Rochko
connection (#14524)
2020-08-09Cache result of SQL (#14534)niwatori24
2020-08-08Merge branch 'master' into glitch-soc/merge-upstreamThibaut Girka
2020-08-08Fix crash when failing to load emoji picker (#14525)ThibG
Fixes #14523
2020-08-07Fix eslint error (#14521)abcang
2020-08-05Fallback to previous, more approximative hashtag RE on older browsers (#14513)ThibG
Fixes #14511
2020-08-05[Glitch] Fallback to previous, more approximative hashtag RE on older browsersThibaut Girka
Signed-off-by: Thibaut Girka <thib@sitedethib.com>
2020-08-04Add support for direct message assertionsFire Demon
2020-08-02[Glitch] Fix audio player on SafariThibG
Port 635b6a0f1af21bd4055f950930a681aa0a96535b to glitch-soc Signed-off-by: Thibaut Girka <thib@sitedethib.com>
2020-08-02Merge branch 'master' into glitch-soc/merge-upstreamThibaut Girka
2020-08-02Fix audio/video player not using CDN_HOST in media paths on public pages ↵ThibG
(#14486)
2020-08-02Fix audio player on Safari (#14485)ThibG
2020-08-02[Glitch] Fix new audio player features not working on SafariThibG
Port 51b5bb53015df5b360f0e366f7fc67dce75e2d6c to glitch-soc Signed-off-by: Thibaut Girka <thib@sitedethib.com>
2020-08-02[Glitch] Fix wrong proptypes for onEditAccountNoteThibG
Port 5faf2de93891db822d78c92f2bc2cdc33c3605c1 to glitch-soc Signed-off-by: Thibaut Girka <thib@sitedethib.com>
2020-08-02[Glitch] Fix the hashtag judgment of the compose form to be the same as the ↵kedama
server side Port cd94854e7d14b2bc755510493944a3e01f758fa2 to glitch-soc Signed-off-by: Thibaut Girka <thib@sitedethib.com>
2020-08-02Merge branch 'master' into glitch-soc/merge-upstreamThibaut Girka
2020-08-02Fix disabled boost icon being replaced by private boost icon on hover (#14456)ThibG
Fixes #14455
2020-08-02Fix new audio player features not working on Safari (#14465)ThibG
Fixes #14462
2020-08-02Fix wrong proptypes for onEditAccountNote (#14481)ThibG
Also add missing PropTypes to the correct component Fixes #14478
2020-08-02Fix the hashtag judgment of the compose form to be the same as the server ↵kedama
side (#14484)
2020-08-01Merge branch 'master' into glitch-soc/merge-upstreamThibaut Girka
Conflicts: - `yarn.lock`: No real conflict, just a glitch-soc-only dependency textually too close to one updated upstream. Ported upstream changes.
2020-08-01Fix handling of Reject Follow when a matching follow relationship exists ↵ThibG
(#14479) * Add tests * Fix handling of Reject Follow when a matching follow relationship exists Regression from #12199
2020-07-26Fix following restriction not working when exact match in account search ↵Takeshi Umeda
(#14394)
2020-07-25Fix local-only toots not being returned by the local TL APIThibaut Girka
Fixes #1389
2020-07-24Fix unnecessary second connection to user stream from account timeline in ↵Eugen Rochko
web UI (#14387) Fix regression from #14212