about summary refs log tree commit diff
path: root/spec/controllers/settings/two_factor_authentications_controller_spec.rb
blob: 922231ded60487a5f83c3653df045a54534a9f1c (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
# frozen_string_literal: true

require 'rails_helper'

describe Settings::TwoFactorAuthenticationsController do
  render_views

  let(:user) { Fabricate(:user) }

  describe 'GET #show' do
    context 'when signed in' do
      before do
        sign_in user, scope: :user
      end

      describe 'when user requires otp for login already' do
        it 'returns http success' do
          user.update(otp_required_for_login: true)
          get :show

          expect(response).to have_http_status(200)
        end
      end

      describe 'when user does not require otp for login' do
        it 'returns http success' do
          user.update(otp_required_for_login: false)
          get :show

          expect(response).to have_http_status(200)
        end
      end
    end

    context 'when not signed in' do
      it 'redirects' do
        get :show
        expect(response).to redirect_to '/auth/sign_in'
      end
    end
  end

  describe 'POST #create' do
    context 'when signed in' do
      before do
        sign_in user, scope: :user
      end

      describe 'when user requires otp for login already' do
        it 'redirects to show page' do
          user.update(otp_required_for_login: true)
          post :create

          expect(response).to redirect_to(settings_two_factor_authentication_path)
        end
      end

      describe 'when creation succeeds' do
        it 'updates user secret' do
          before = user.otp_secret
          post :create

          expect(user.reload.otp_secret).not_to eq(before)
          expect(response).to redirect_to(new_settings_two_factor_authentication_confirmation_path)
        end
      end
    end

    context 'when not signed in' do
      it 'redirects' do
        get :show
        expect(response).to redirect_to '/auth/sign_in'
      end
    end
  end

  describe 'POST #destroy' do
    before do
      user.update(otp_required_for_login: true)
    end

    context 'when signed in' do
      before do
        sign_in user, scope: :user
      end

      it 'turns off otp requirement with correct code' do
        expect_any_instance_of(User).to receive(:validate_and_consume_otp!) do |value, arg|
          expect(value).to eq user
          expect(arg).to eq '123456'
          true
        end

        post :destroy, params: { form_two_factor_confirmation: { otp_attempt: '123456' } }

        expect(response).to redirect_to(settings_two_factor_authentication_path)
        user.reload
        expect(user.otp_required_for_login).to eq(false)
      end

      it 'does not turn off otp if code is incorrect' do
        expect_any_instance_of(User).to receive(:validate_and_consume_otp!) do |value, arg|
          expect(value).to eq user
          expect(arg).to eq '057772'
          false
        end

        post :destroy, params: { form_two_factor_confirmation: { otp_attempt: '057772' } }

        user.reload
        expect(user.otp_required_for_login).to eq(true)
      end

      it 'raises ActionController::ParameterMissing if code is missing' do
        post :destroy
        expect(response).to have_http_status(400)
      end
    end

    it 'redirects if not signed in' do
      get :show
      expect(response).to redirect_to '/auth/sign_in'
    end
  end
end