about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJoël Quenneville <joel.quen@gmail.com>2017-04-28 18:21:35 -0400
committerEugen Rochko <eugen@zeonfederated.com>2017-04-29 00:21:35 +0200
commit27301312a698e0fd2d1898d9e1c579d7f9ee861f (patch)
treea200409867bf475435bb8c1d26cd8d1963534120
parent8ac7fca5d06b776cc09127f9c6a9018e9acade5b (diff)
Add tests to the Feed model (#2594)
This adds a test for the `Feed#get` method. While the data
transformations in `Feed#get` may seem redundant, they are important to
maintain the order from Redis. The tests I wrote will fail if someone
tries to refactor away this "redundancy" (as I tried to do in the first
iteration of this change).
-rw-r--r--spec/models/feed_spec.rb16
1 files changed, 15 insertions, 1 deletions
diff --git a/spec/models/feed_spec.rb b/spec/models/feed_spec.rb
index 19ddeef7f..96c477073 100644
--- a/spec/models/feed_spec.rb
+++ b/spec/models/feed_spec.rb
@@ -2,6 +2,20 @@ require 'rails_helper'
 
 RSpec.describe Feed, type: :model do
   describe '#get' do
-    pending
+    it "gets statuses with ids in the range, maintining the order from Redis" do
+      account = Fabricate(:account)
+      Fabricate(:status, account: account, id: 1)
+      Fabricate(:status, account: account, id: 2)
+      Fabricate(:status, account: account, id: 3)
+      Fabricate(:status, account: account, id: 10)
+      redis = double(zrevrangebyscore: [["val2", 2.0], ["val1", 1.0], ["val3", 3.0], ["deleted", 4.0]])
+      allow(Redis).to receive(:current).and_return(redis)
+
+      feed = Feed.new("type", account)
+      results = feed.get(3)
+
+      expect(results.map(&:id)).to eq [2, 1, 3]
+      expect(results.first.attributes.keys).to eq ["id", "updated_at"]
+    end
   end
 end