diff options
author | Eugen Rochko <eugen@zeonfederated.com> | 2019-06-07 17:15:18 +0200 |
---|---|---|
committer | multiple creatures <dev@multiple-creature.party> | 2020-02-22 01:29:06 -0600 |
commit | 27f826b5b12441e2de64015c42f736e865a146b2 (patch) | |
tree | aec25a8adca855f235d513e6c637e9096ec96b93 | |
parent | 92b9c17bf4ee0b29041b9a72b9c3de4705b47494 (diff) |
[Glitch] Fix some React warnings
Port cc8f6b3cdaca81be99875c27002e0280d1d88191 to glitch-soc Signed-off-by: Thibaut Girka <thib@sitedethib.com>
-rw-r--r-- | app/javascript/flavours/glitch/components/autosuggest_textarea.js | 5 | ||||
-rw-r--r-- | app/javascript/flavours/glitch/features/compose/components/compose_form.js | 12 |
2 files changed, 10 insertions, 7 deletions
diff --git a/app/javascript/flavours/glitch/components/autosuggest_textarea.js b/app/javascript/flavours/glitch/components/autosuggest_textarea.js index 7a6b9d8ac..bbe0ffcbe 100644 --- a/app/javascript/flavours/glitch/components/autosuggest_textarea.js +++ b/app/javascript/flavours/glitch/components/autosuggest_textarea.js @@ -201,7 +201,7 @@ export default class AutosuggestTextarea extends ImmutablePureComponent { } return [ - <div className='compose-form__autosuggest-wrapper'> + <div className='compose-form__autosuggest-wrapper' key='autosuggest-wrapper'> <div className='autosuggest-textarea'> <label> <span style={{ display: 'none' }}>{placeholder}</span> @@ -226,7 +226,8 @@ export default class AutosuggestTextarea extends ImmutablePureComponent { </div> {children} </div>, - <div className='autosuggest-textarea__suggestions-wrapper'> + + <div className='autosuggest-textarea__suggestions-wrapper' key='suggestions-wrapper'> <div className={`autosuggest-textarea__suggestions ${suggestionsHidden || suggestions.isEmpty() ? '' : 'autosuggest-textarea__suggestions--visible'}`}> {suggestions.map(this.renderSuggestion)} </div> diff --git a/app/javascript/flavours/glitch/features/compose/components/compose_form.js b/app/javascript/flavours/glitch/features/compose/components/compose_form.js index de89b7266..2ec77f61b 100644 --- a/app/javascript/flavours/glitch/features/compose/components/compose_form.js +++ b/app/javascript/flavours/glitch/features/compose/components/compose_form.js @@ -31,10 +31,6 @@ const messages = defineMessages({ export default @injectIntl class ComposeForm extends ImmutablePureComponent { - setRef = c => { - this.composeForm = c; - }; - static contextTypes = { router: PropTypes.object, }; @@ -151,6 +147,10 @@ class ComposeForm extends ImmutablePureComponent { } } + setRef = c => { + this.composeForm = c; + }; + // Inserts an emoji at the caret. handleEmoji = (data) => { const { textarea: { selectionStart } } = this; @@ -223,7 +223,9 @@ class ComposeForm extends ImmutablePureComponent { } handleFocus = () => { - this.composeForm.scrollIntoView(); + if (this.composeForm) { + this.composeForm.scrollIntoView(); + } } // This statement does several things: |