about summary refs log tree commit diff
diff options
context:
space:
mode:
authorClaire <claire.github-309c@sitedethib.com>2021-08-11 16:41:59 +0200
committerClaire <claire.github-309c@sitedethib.com>2021-08-11 16:41:59 +0200
commit47ea9b2d677b380e09d79958ae1c988f031cdf75 (patch)
treedeb1c1549b7ad575074e5913aaad55d8a85d2ddf
parent70b7ac9ff32a713e71a7ba6408a379b601c6839f (diff)
parent13b08610a08faf2909f7c871be62da955d9293d3 (diff)
Merge branch 'main' into glitch-soc/merge-upstream
-rw-r--r--.circleci/config.yml2
-rw-r--r--.nvmrc2
-rw-r--r--Dockerfile4
-rw-r--r--Vagrantfile2
-rw-r--r--app/models/account.rb6
-rw-r--r--spec/services/activitypub/process_account_service_spec.rb1
6 files changed, 11 insertions, 6 deletions
diff --git a/.circleci/config.yml b/.circleci/config.yml
index 42c058295..bfded07de 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -209,7 +209,7 @@ jobs:
   test-webui:
     <<: *defaults
     docker:
-      - image: circleci/node:12-buster
+      - image: circleci/node:14-buster
     steps:
       - *attach_workspace
       - run:
diff --git a/.nvmrc b/.nvmrc
index 48082f72f..8351c1939 100644
--- a/.nvmrc
+++ b/.nvmrc
@@ -1 +1 @@
-12
+14
diff --git a/Dockerfile b/Dockerfile
index 8279e8735..fb596fdbf 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -3,8 +3,8 @@ FROM ubuntu:20.04 as build-dep
 # Use bash for the shell
 SHELL ["/bin/bash", "-c"]
 
-# Install Node v12 (LTS)
-ENV NODE_VER="12.21.0"
+# Install Node v14 (LTS)
+ENV NODE_VER="14.17.4"
 RUN ARCH= && \
     dpkgArch="$(dpkg --print-architecture)" && \
   case "${dpkgArch##*-}" in \
diff --git a/Vagrantfile b/Vagrantfile
index 2afed9279..25f563d95 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -12,7 +12,7 @@ curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -
 sudo apt-add-repository 'deb https://dl.yarnpkg.com/debian/ stable main'
 
 # Add repo for NodeJS
-curl -sL https://deb.nodesource.com/setup_12.x | sudo bash -
+curl -sL https://deb.nodesource.com/setup_14.x | sudo bash -
 
 # Add firewall rule to redirect 80 to PORT and save
 sudo iptables -t nat -A PREROUTING -p tcp --dport 80 -j REDIRECT --to-port #{ENV["PORT"]}
diff --git a/app/models/account.rb b/app/models/account.rb
index 3178a0f9c..ab3cac0d6 100644
--- a/app/models/account.rb
+++ b/app/models/account.rb
@@ -299,7 +299,11 @@ class Account < ApplicationRecord
   end
 
   def fields
-    (self[:fields] || []).map { |f| Field.new(self, f) }
+    (self[:fields] || []).map do |f|
+      Field.new(self, f)
+    rescue
+      nil
+    end.compact
   end
 
   def fields_attributes=(attributes)
diff --git a/spec/services/activitypub/process_account_service_spec.rb b/spec/services/activitypub/process_account_service_spec.rb
index 56e7f8321..1b1d878a7 100644
--- a/spec/services/activitypub/process_account_service_spec.rb
+++ b/spec/services/activitypub/process_account_service_spec.rb
@@ -12,6 +12,7 @@ RSpec.describe ActivityPub::ProcessAccountService, type: :service do
         attachment: [
           { type: 'PropertyValue', name: 'Pronouns', value: 'They/them' },
           { type: 'PropertyValue', name: 'Occupation', value: 'Unit test' },
+          { type: 'PropertyValue', name: 'non-string', value: ['foo', 'bar'] },
         ],
       }.with_indifferent_access
     end