diff options
| author | Claire <claire.github-309c@sitedethib.com> | 2023-03-15 04:15:20 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-15 04:15:20 +0100 |
| commit | a232a1feb804e22507ca104ca0aaf21a7c70cb26 (patch) | |
| tree | cbd368766f85667ac793072b0075d124292205b2 | |
| parent | cf50667e26853d2d0f78ec1226db84995c4b83f4 (diff) | |
Fix misleading error code when receiving invalid WebAuthn credentials (#23568)
| -rw-r--r-- | app/controllers/settings/two_factor_authentication/webauthn_credentials_controller.rb | 2 | ||||
| -rw-r--r-- | spec/controllers/settings/two_factor_authentication/webauthn_credentials_controller_spec.rb | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/app/controllers/settings/two_factor_authentication/webauthn_credentials_controller.rb b/app/controllers/settings/two_factor_authentication/webauthn_credentials_controller.rb index e43818c94..d1ee7dc19 100644 --- a/app/controllers/settings/two_factor_authentication/webauthn_credentials_controller.rb +++ b/app/controllers/settings/two_factor_authentication/webauthn_credentials_controller.rb @@ -52,7 +52,7 @@ module Settings end else flash[:error] = I18n.t('webauthn_credentials.create.error') - status = :internal_server_error + status = :unprocessable_entity end else flash[:error] = t('webauthn_credentials.create.error') diff --git a/spec/controllers/settings/two_factor_authentication/webauthn_credentials_controller_spec.rb b/spec/controllers/settings/two_factor_authentication/webauthn_credentials_controller_spec.rb index f060c3a4b..a95521c94 100644 --- a/spec/controllers/settings/two_factor_authentication/webauthn_credentials_controller_spec.rb +++ b/spec/controllers/settings/two_factor_authentication/webauthn_credentials_controller_spec.rb @@ -248,7 +248,7 @@ describe Settings::TwoFactorAuthentication::WebauthnCredentialsController do post :create, params: { credential: new_webauthn_credential, nickname: 'USB Key' } - expect(response).to have_http_status(500) + expect(response).to have_http_status(422) expect(flash[:error]).to be_present end end @@ -268,7 +268,7 @@ describe Settings::TwoFactorAuthentication::WebauthnCredentialsController do post :create, params: { credential: new_webauthn_credential, nickname: nickname } - expect(response).to have_http_status(500) + expect(response).to have_http_status(422) expect(flash[:error]).to be_present end end |