diff options
| author | Matt Jankowski <mjankowski@thoughtbot.com> | 2017-04-10 18:38:34 -0400 |
|---|---|---|
| committer | Eugen <eugen@zeonfederated.com> | 2017-04-11 00:38:34 +0200 |
| commit | b57eed4584fbaa3bf83964bda804f27495b6f1fc (patch) | |
| tree | 98827a05d98ae46c3c261cce09e2945baccc1d2e | |
| parent | 3672a799d4bf9011bc665b6d8f55e58031513527 (diff) | |
Remove order prior to .find_in_batches (#1470)
The `Status` class has a default order on it, so when this query gets built and gets all the way to `find_in_batches` there is an order already there. When `find_in_batches` is run it discards any existing order on the query, and emits a warning to the logs if there is one there. This change removes the order prior calling `find_in_batches`, which will stop the logged warning from occurring as well.
| -rw-r--r-- | app/lib/feed_manager.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/lib/feed_manager.rb b/app/lib/feed_manager.rb index 58d9fb1fc..339a5c78b 100644 --- a/app/lib/feed_manager.rb +++ b/app/lib/feed_manager.rb @@ -66,7 +66,7 @@ class FeedManager timeline_key = key(:home, into_account.id) oldest_home_score = redis.zrange(timeline_key, 0, 0, with_scores: true)&.first&.last&.to_i || 0 - from_account.statuses.select('id').where('id > ?', oldest_home_score).find_in_batches do |statuses| + from_account.statuses.select('id').where('id > ?', oldest_home_score).reorder(nil).find_in_batches do |statuses| redis.pipelined do statuses.each do |status| redis.zrem(timeline_key, status.id) |