diff options
| author | Claire <claire.github-309c@sitedethib.com> | 2022-12-15 17:45:02 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-15 17:45:02 +0100 |
| commit | 8556a649d58a7291db6942a2594533f9b8c06165 (patch) | |
| tree | 8617e90f84082e8ba35160f8b2a3772812216a4f /app/controllers/admin | |
| parent | 1e49be33289b969be64620b904d589158e7b579a (diff) | |
Fix changing domain block severity not undoing individual account effects (#22135)
* Fix changing domain block severity not undoing individual account effects Fixes #22133 * Add tests
Diffstat (limited to 'app/controllers/admin')
| -rw-r--r-- | app/controllers/admin/domain_blocks_controller.rb | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/app/controllers/admin/domain_blocks_controller.rb b/app/controllers/admin/domain_blocks_controller.rb index e79f7a43e..74764640b 100644 --- a/app/controllers/admin/domain_blocks_controller.rb +++ b/app/controllers/admin/domain_blocks_controller.rb @@ -55,12 +55,8 @@ module Admin def update authorize :domain_block, :update? - @domain_block.update(update_params) - - severity_changed = @domain_block.severity_changed? - - if @domain_block.save - DomainBlockWorker.perform_async(@domain_block.id, severity_changed) + if @domain_block.update(update_params) + DomainBlockWorker.perform_async(@domain_block.id, @domain_block.severity_previously_changed?) log_action :update, @domain_block redirect_to admin_instances_path(limited: '1'), notice: I18n.t('admin.domain_blocks.created_msg') else |